From: Matthew Wilcox <matthew@wil.cx>
To: Gerb Stralko <gerb.stralko@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: remove CDROM not ready printk
Date: Thu, 29 May 2008 08:51:31 -0600 [thread overview]
Message-ID: <20080529145131.GS22636@parisc-linux.org> (raw)
In-Reply-To: <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com>
On Thu, May 29, 2008 at 10:35:08AM -0400, Gerb Stralko wrote:
> On Thu, May 29, 2008 at 10:05 AM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > That's correct. cgc is the data from the packet command that was sent
> > in from the ioctl. The user application is actually the one that
> > decides whether you get to see the message or not. Modern apps like hal
> > set it because they take care of all state updates and notifications
> > themselves. Which is the application that's doing this (because it
> > probably needs updating).
>
> So is that printk really needed? Should the kernel even need to print
> a message like that, esp. if user-space is handling state updates and
> notifications. Or do i need to configure hald to be quietier? FWIW
> I'm using fedora core 9 and hald version:
> -bash-3.2$ /usr/sbin/hald --version
> HAL package version: 0.5.11
I think you misunderstood. James is saying that an app like HAL will
set the ->quiet flag. You must be using some other application that
isn't setting the ->quiet flag. Any idea what this other application
is?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-05-29 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.1.10.0805271502370.3985@localhost.localdomain>
2008-05-29 7:41 ` [PATCH] scsi: remove CDROM not ready printk Andrew Morton
2008-05-29 14:05 ` James Bottomley
2008-05-29 14:35 ` Gerb Stralko
2008-05-29 14:51 ` Matthew Wilcox [this message]
2008-05-29 14:55 ` James Bottomley
2008-05-29 15:04 ` Gerb Stralko
2008-05-29 15:22 ` James Bottomley
2008-06-02 0:45 ` Gerb Stralko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080529145131.GS22636@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=gerb.stralko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).