* [PATCH 2/3] sd: Allow sd_print_sense_hdr to be called outside of sd.c
@ 2008-06-06 19:25 Martin K. Petersen
2008-06-09 7:06 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2008-06-06 19:25 UTC (permalink / raw)
To: linux-scsi
sd: Allow sd_print_sense_hdr to be called outside of sd.c
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff -r 431a96f963a6 drivers/scsi/sd.c
--- a/drivers/scsi/sd.c Fri Apr 25 13:36:00 2008 -0400
+++ b/drivers/scsi/sd.c Fri Apr 25 13:36:39 2008 -0400
@@ -96,7 +96,6 @@
static int sd_done(struct scsi_cmnd *);
static void sd_read_capacity(struct scsi_disk *sdkp, unsigned char *buffer);
static void scsi_disk_release(struct device *cdev);
-static void sd_print_sense_hdr(struct scsi_disk *, struct scsi_sense_hdr *);
static void sd_print_result(struct scsi_disk *, int);
static DEFINE_IDR(sd_index_idr);
@@ -1930,14 +1929,14 @@
module_init(init_sd);
module_exit(exit_sd);
-static void sd_print_sense_hdr(struct scsi_disk *sdkp,
- struct scsi_sense_hdr *sshdr)
+void sd_print_sense_hdr(struct scsi_disk *sdkp, struct scsi_sense_hdr *sshdr)
{
sd_printk(KERN_INFO, sdkp, "");
scsi_show_sense_hdr(sshdr);
sd_printk(KERN_INFO, sdkp, "");
scsi_show_extd_sense(sshdr->asc, sshdr->ascq);
}
+EXPORT_SYMBOL(sd_print_sense_hdr);
static void sd_print_result(struct scsi_disk *sdkp, int result)
{
diff -r 431a96f963a6 drivers/scsi/sd.h
--- a/drivers/scsi/sd.h Fri Apr 25 13:36:00 2008 -0400
+++ b/drivers/scsi/sd.h Fri Apr 25 13:36:39 2008 -0400
@@ -48,6 +48,8 @@
};
#define to_scsi_disk(obj) container_of(obj,struct scsi_disk,dev)
+extern void sd_print_sense_hdr(struct scsi_disk *, struct scsi_sense_hdr *);
+
#define sd_printk(prefix, sdsk, fmt, a...) \
(sdsk)->disk ? \
sdev_printk(prefix, (sdsk)->device, "[%s] " fmt, \
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] sd: Allow sd_print_sense_hdr to be called outside of sd.c
2008-06-06 19:25 [PATCH 2/3] sd: Allow sd_print_sense_hdr to be called outside of sd.c Martin K. Petersen
@ 2008-06-09 7:06 ` Christoph Hellwig
2008-06-09 15:07 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-06-09 7:06 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: linux-scsi
On Fri, Jun 06, 2008 at 03:25:20PM -0400, Martin K. Petersen wrote:
> +EXPORT_SYMBOL(sd_print_sense_hdr);
no need to export it, it should only be called from sd_mod.ko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] sd: Allow sd_print_sense_hdr to be called outside of sd.c
2008-06-09 7:06 ` Christoph Hellwig
@ 2008-06-09 15:07 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2008-06-09 15:07 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Martin K. Petersen, linux-scsi
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
Christoph> On Fri, Jun 06, 2008 at 03:25:20PM -0400, Martin K. Petersen wrote:
>> +EXPORT_SYMBOL(sd_print_sense_hdr);
Christoph> no need to export it, it should only be called from
Christoph> sd_mod.ko
Legacy cruft. Fixed.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-09 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-06 19:25 [PATCH 2/3] sd: Allow sd_print_sense_hdr to be called outside of sd.c Martin K. Petersen
2008-06-09 7:06 ` Christoph Hellwig
2008-06-09 15:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox