Re: [RFC] Set functions for scsi_cmnd result

[Christof Schmitt <christof.schmitt@de.ibm.com>]

On Thu, Jun 12, 2008 at 10:55:41AM -0500, James Bottomley wrote:
> > --- a/include/scsi/scsi.h	2008-06-10 17:30:49.000000000 +0200
> > +++ b/include/scsi/scsi.h	2008-06-12 11:06:34.000000000 +0200
> > @@ -425,6 +425,16 @@ struct scsi_lun {
> >  #define driver_byte(result) (((result) >> 24) & 0xff)
> >  #define suggestion(result)  (driver_byte(result) & SUGGEST_MASK)
> >  
> > +static inline void set_host_byte(int *result, char status)
> > +{
> > +	*result |= status << 16;
> > +}
> > +
> > +static inline void set_driver_byte(int *result, char status)
> > +{
> > +	*result |= status << 24;
> > +}
> > +
> 
> If we're making accessors, it might be better if they took a struct
> scsi_cmnd rather than a pointer to one of its elements.  Other than
> that, this looks fine.

Ok. I will update the patch and send it with the next batch of zfcp
patches.

Christof