[PATCH 1/4] Fix SES timeout

public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/4] Fix SES timeout
@ 2008-06-23 15:14 Matthew Wilcox
  2008-06-23 15:39 ` James Bottomley
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2008-06-23 15:14 UTC (permalink / raw)
  To: linux-scsi

Timeouts are measured in jiffies, not in seconds.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index 45df83b..351bce7 100644
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -61,7 +61,7 @@ static int ses_probe(struct device *dev)
 	return err;
 }
 
-#define SES_TIMEOUT 30
+#define SES_TIMEOUT (30 * HZ)
 #define SES_RETRIES 3
 
 static int ses_recv_diag(struct scsi_device *sdev, int page_code,

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/4] Fix SES timeout
  2008-06-23 15:14 [PATCH 1/4] Fix SES timeout Matthew Wilcox
@ 2008-06-23 15:39 ` James Bottomley
  0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2008-06-23 15:39 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: linux-scsi

On Mon, 2008-06-23 at 09:14 -0600, Matthew Wilcox wrote:
> Timeouts are measured in jiffies, not in seconds.

That's a bit of a brown paper bag one; thanks.

It's not really part of the series (fortunately) because it needs to be
in -rc fixes and backported to stable.

James



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-23 15:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 15:14 [PATCH 1/4] Fix SES timeout Matthew Wilcox
2008-06-23 15:39 ` James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox