Re: [PATCH] esp: tidy up target reference counting

James Bottomley
2008-06-24T16:28:08Z

On Mon, 2008-06-23 at 14:58 -0700, David Miller wrote:
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date: Mon, 23 Jun 2008 14:52:09 -0500
>
> > The esp driver currently does hand rolled reference counting of its
> > target. It's much easier to do what it needs to do if it's plugged into
> > the mid-layer callbacks (target_alloc and target_destroy) which were
> > designed for this case, so do it this way and get rid of the internal
> > target reference count.
> >
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> Much cleaner, thanks!
>
> Signed-off-by: David S. Miller <davem@davemloft.net>

You're welcome ... I actually initially queued this for the merge
window, but since this looks like it fixes a bug that would affect any
multi-lun installation, isn't it a candidate for the current git head
(and indeed for stable), or isn't there that much of a multi-lun install
base with this driver to worry about?

James