[PATCH] convert struct scsi_varlen_cdb_hdr in scsi.h to use __u8 for user space

[PATCH] convert struct scsi_varlen_cdb_hdr in scsi.h to use __u8 for user space

[FUJITA Tomonori]

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 include/scsi/scsi.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 32742c4..01e07a5 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -137,10 +137,10 @@
 
 /* defined in T10 SCSI Primary Commands-2 (SPC2) */
 struct scsi_varlen_cdb_hdr {
-	u8 opcode;        /* opcode always == VARIABLE_LENGTH_CMD */
-	u8 control;
-	u8 misc[5];
-	u8 additional_cdb_length;         /* total cdb length - 8 */
+	__u8 opcode;        /* opcode always == VARIABLE_LENGTH_CMD */
+	__u8 control;
+	__u8 misc[5];
+	__u8 additional_cdb_length;         /* total cdb length - 8 */
 	__be16 service_action;
 	/* service specific data follows */
 };
-- 
1.5.4.2

Re: [PATCH] convert struct scsi_varlen_cdb_hdr in scsi.h to use __u8 for user space

[Matthew Wilcox]

But we don't install anything in include/scsi to userspace:

$ cat include/Kbuild 
header-y += asm-generic/
header-y += linux/
header-y += sound/
header-y += mtd/
header-y += rdma/
header-y += video/

header-y += asm-$(ARCH)/

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] convert struct scsi_varlen_cdb_hdr in scsi.h to use __u8 for user space

[FUJITA Tomonori]

On Sun, 29 Jun 2008 06:43:46 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> 
> But we don't install anything in include/scsi to userspace:
> 
> $ cat include/Kbuild 
> header-y += asm-generic/
> header-y += linux/
> header-y += sound/
> header-y += mtd/
> header-y += rdma/
> header-y += video/
> 
> header-y += asm-$(ARCH)/

Yeah, we don't now but it had been exported to user space, I
guess.

People who still use it in user space should fix their problem. But
using __u8 doesn't hurt anyone. I just thought it would be a bit nicer
to do that.

Re: [PATCH] convert struct scsi_varlen_cdb_hdr in scsi.h to use __u8 for user space

[Matthew Wilcox]

On Sun, Jun 29, 2008 at 10:02:03PM +0900, FUJITA Tomonori wrote:
> On Sun, 29 Jun 2008 06:43:46 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
> 
> > 
> > But we don't install anything in include/scsi to userspace:
> 
> Yeah, we don't now but it had been exported to user space, I
> guess.

I believe glibc provides /usr/include/scsi and has for some time.  Maybe
we should change that now that we have the Kbuild infrastructure to
export headers to userspace sanely.

Doug, what do you think?  You must be the biggest user of include/scsi
in userspace.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."