Re: [patch 07/11] zfcp: Cleanup of code in zfcp_aux.c

Christof Schmitt
2008-07-02T07:04:53Z

On Tue, Jul 01, 2008 at 03:44:13PM +0200, Swen Schillig wrote:
> > Sorry, but this still seems to be incorrect. strsep modifies the string that
> > gets passed to it. In this case you let it operate on the original module
> > parameter string which is also exported via sysfs.
> > So after parsing finished the exported string is much shorter than the
> > original string. That was actually the whole point why the old code allocated
> > memory and copied the string so the copy could be modified.
> > A comment would have been good ;)
> > --
> Correct,
>
> I fixed the patch and Christof will send it soon to the list.

While testing this, i also fixed one issue with the erp patch. To
avoid confusion, i will resend the complete patch series later today.

Christof