Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH -next] scsi: fix advansys printk format warnings
@ 2008-07-16 18:50 Randy Dunlap
  2008-07-16 18:59 ` David Woodhouse
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-07-16 18:50 UTC (permalink / raw)
  To: lkml, dwmw2; +Cc: scsi, jejb

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix printk format warnings (firmware-related):

linux-next-20080716/drivers/scsi/advansys.c:4788: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
linux-next-20080716/drivers/scsi/advansys.c:5117: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
linux-next-20080716/drivers/scsi/advansys.c:5631: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
linux-next-20080716/drivers/scsi/advansys.c:6131: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/advansys.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20080716.orig/drivers/scsi/advansys.c
+++ linux-next-20080716/drivers/scsi/advansys.c
@@ -4784,7 +4784,7 @@ static ushort AscInitAsc1000Driver(ASC_D
 		return err;
 	}
 	if (fw->size < 4) {
-		printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
+		printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
 		       fw->size, fwname);
 		release_firmware(fw);
 		return -EINVAL;
@@ -5113,7 +5113,7 @@ static int AdvInitAsc3550Driver(ADV_DVC_
 		return err;
 	}
 	if (fw->size < 4) {
-		printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
+		printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
 		       fw->size, fwname);
 		release_firmware(fw);
 		return -EINVAL;
@@ -5627,7 +5627,7 @@ static int AdvInitAsc38C0800Driver(ADV_D
 		return err;
 	}
 	if (fw->size < 4) {
-		printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
+		printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
 		       fw->size, fwname);
 		release_firmware(fw);
 		return -EINVAL;
@@ -6127,7 +6127,7 @@ static int AdvInitAsc38C1600Driver(ADV_D
 		return err;
 	}
 	if (fw->size < 4) {
-		printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
+		printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
 		       fw->size, fwname);
 		release_firmware(fw);
 		return -EINVAL;


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: fix advansys printk format warnings
  2008-07-16 18:50 [PATCH -next] scsi: fix advansys printk format warnings Randy Dunlap
@ 2008-07-16 18:59 ` David Woodhouse
  2008-07-16 19:20   ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2008-07-16 18:59 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, scsi, jejb, jaswinder

On Wed, 2008-07-16 at 11:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix printk format warnings (firmware-related):
> 
> linux-next-20080716/drivers/scsi/advansys.c:4788: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> linux-next-20080716/drivers/scsi/advansys.c:5117: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> linux-next-20080716/drivers/scsi/advansys.c:5631: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> linux-next-20080716/drivers/scsi/advansys.c:6131: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'


Thanks. We'll roll those into the original patches, if that's OK with
you.

-- 
dwmw2     @linux.intel.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: fix advansys printk format warnings
  2008-07-16 18:59 ` David Woodhouse
@ 2008-07-16 19:20   ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-07-16 19:20 UTC (permalink / raw)
  To: David Woodhouse; +Cc: lkml, scsi, jejb, jaswinder

On Wed, 16 Jul 2008 11:59:33 -0700 David Woodhouse wrote:

> On Wed, 2008-07-16 at 11:50 -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Fix printk format warnings (firmware-related):
> > 
> > linux-next-20080716/drivers/scsi/advansys.c:4788: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> > linux-next-20080716/drivers/scsi/advansys.c:5117: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> > linux-next-20080716/drivers/scsi/advansys.c:5631: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> > linux-next-20080716/drivers/scsi/advansys.c:6131: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> 
> 
> Thanks. We'll roll those into the original patches, if that's OK with
> you.

Ack.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-16 19:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-16 18:50 [PATCH -next] scsi: fix advansys printk format warnings Randy Dunlap
2008-07-16 18:59 ` David Woodhouse
2008-07-16 19:20   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox