From: "Darrick J. Wong" <djwong@us.ibm.com>
To: rae l <crquan@gmail.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/scsi/aic94xx/: replace __FUNCTION__ with __func__
Date: Fri, 25 Jul 2008 13:11:26 -0700 [thread overview]
Message-ID: <20080725201126.GB7355@tree.beaverton.ibm.com> (raw)
In-Reply-To: <91b13c310807251008o361bc39drfb6aa227cd9fd2f9@mail.gmail.com>
On Sat, Jul 26, 2008 at 01:08:38AM +0800, rae l wrote:
> On Sat, Jul 26, 2008 at 12:42 AM, Darrick J. Wong <djwong@us.ibm.com> wrote:
> > On Fri, Jul 25, 2008 at 10:48:33AM +0800, Denis ChengRq wrote:
> >> Signed-off-by: Denis ChengRq <crquan@gmail.com>
> >
> > No justification or changelog?
> I think no more explanation needed, the subject is definite.
>
> and no justification happened here, (there are justifications otherwhere)
It's not clear to _me_ the _reason_ for changing this. I think you're
trying to implement C99 cleanups, but I don't know for sure and this is
the first I've heard of __FUNCTION__ -> __func__ changes.
Really all I wanted was the two words "per C99" at the end of the title
so that I don't have a "Why the heck did we change this?" moment six
months from now. :)
--D
next prev parent reply other threads:[~2008-07-25 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 2:48 [PATCH 2/5] drivers/scsi/aic94xx/: replace __FUNCTION__ with __func__ Denis ChengRq
2008-07-25 2:48 ` [PATCH 5/5] drivers/scsi/ core: " Denis ChengRq
2008-07-25 16:42 ` [PATCH 2/5] drivers/scsi/aic94xx/: " Darrick J. Wong
2008-07-25 17:08 ` rae l
2008-07-25 17:14 ` James Bottomley
2008-07-25 20:11 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-25 2:47 Denis ChengRq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725201126.GB7355@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=crquan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox