From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 10/12] lkdtm: fix for CONFIG_SCSI=n Date: Wed, 30 Jul 2008 13:42:43 -0700 Message-ID: <20080730134243.d2b9894b.akpm@linux-foundation.org> References: <200807301944.m6UJiSab012906@imap1.linux-foundation.org> <1217449008.3335.39.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:54047 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbYG3Unh (ORCPT ); Wed, 30 Jul 2008 16:43:37 -0400 In-Reply-To: <1217449008.3335.39.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi@vger.kernel.org, randy.dunlap@oracle.com, ankita@in.ibm.com, Sam Ravnborg On Wed, 30 Jul 2008 15:16:48 -0500 James Bottomley wrote: > On Wed, 2008-07-30 at 12:44 -0700, akpm@linux-foundation.org wrote: > > From: Randy Dunlap > > > > From: Randy Dunlap > > > > Fix lkdtm test code for case of CONFIG_SCSI=n, to avoid build errors: > > > > In file included from linux-next-20080618/tests/lkdtm.c:55: > > linux-next-20080618/include/scsi/scsi_cmnd.h:28:25: warning: "BLK_MAX_CDB" is not defined > > linux-next-20080618/include/scsi/scsi_cmnd.h:29:3: error: #error MAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDB > > In file included from linux-next-20080618/tests/lkdtm.c:55: > > linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_bidi_cmnd': > > linux-next-20080618/include/scsi/scsi_cmnd.h:183: error: implicit declaration of function 'blk_bidi_rq' > > linux-next-20080618/include/scsi/scsi_cmnd.h:184: error: dereferencing pointer to incomplete type > > linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_in': > > linux-next-20080618/include/scsi/scsi_cmnd.h:190: error: dereferencing pointer to incomplete type > > make[2]: *** [tests/lkdtm.o] Error 1 > > > > Signed-off-by: Randy Dunlap > > Acked-by: Ankita Garg > > Signed-off-by: Andrew Morton > > --- > > > > tests/lkdtm.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff -puN tests/lkdtm.c~lkdtm-fix-for-config_scsi=n tests/lkdtm.c > > --- a/tests/lkdtm.c~lkdtm-fix-for-config_scsi=n > > +++ a/tests/lkdtm.c > > OK, you've sent me this one twice now ... what exactly is it? Why didn't you tell me last time? > There's > no tests directory in any kernel tree I have. You don't have a copy of linux-next? Wow. I'll send it to Sam.