* RE: [PATCH] cciss: return -EFAULT if copy_from_user() fails
[not found] <200807311135.48889.knikanth@suse.de>
@ 2008-07-31 14:12 ` Miller, Mike (OS Dev)
2008-08-04 8:58 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Miller, Mike (OS Dev) @ 2008-07-31 14:12 UTC (permalink / raw)
To: Nikanth Karthikesan, LKML, LKML-scsi; +Cc: ISS StorageDev, Jens Axboe
> -----Original Message-----
> From: Nikanth Karthikesan [mailto:knikanth@suse.de]
> Sent: Thursday, July 31, 2008 1:06 AM
> To: Miller, Mike (OS Dev)
> Cc: ISS StorageDev; Jens Axboe
> Subject: [PATCH] cciss: return -EFAULT if copy_from_user() fails
>
> Return -EFAULT instead of -ENOMEM if copy_from_user() fails.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Acked-by: Mike Miller <mike.miller@hp.com>
>
> ---
> drivers/block/cciss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/block/cciss.c
> ===================================================================
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1134,7 +1134,7 @@ static int cciss_ioctl(struct inode *ino
> if
> (ioc->Request.Type.Direction == XFER_WRITE) {
> if (copy_from_user
> (buff[sg_used],
> data_ptr, sz)) {
> - status = -ENOMEM;
> + status = -EFAULT;
> goto cleanup1;
> }
> } else {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cciss: return -EFAULT if copy_from_user() fails
2008-07-31 14:12 ` [PATCH] cciss: return -EFAULT if copy_from_user() fails Miller, Mike (OS Dev)
@ 2008-08-04 8:58 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-08-04 8:58 UTC (permalink / raw)
To: Miller, Mike (OS Dev)
Cc: Nikanth Karthikesan, LKML, LKML-scsi, ISS StorageDev
On Thu, Jul 31 2008, Miller, Mike (OS Dev) wrote:
>
>
> > -----Original Message-----
> > From: Nikanth Karthikesan [mailto:knikanth@suse.de]
> > Sent: Thursday, July 31, 2008 1:06 AM
> > To: Miller, Mike (OS Dev)
> > Cc: ISS StorageDev; Jens Axboe
> > Subject: [PATCH] cciss: return -EFAULT if copy_from_user() fails
> >
> > Return -EFAULT instead of -ENOMEM if copy_from_user() fails.
> >
> > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
>
> Acked-by: Mike Miller <mike.miller@hp.com>
Applied
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-04 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200807311135.48889.knikanth@suse.de>
2008-07-31 14:12 ` [PATCH] cciss: return -EFAULT if copy_from_user() fails Miller, Mike (OS Dev)
2008-08-04 8:58 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox