From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] pci: add misrouted interrupt error handling
Date: Mon, 4 Aug 2008 14:43:20 -0600 [thread overview]
Message-ID: <200808041443.20942.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1217786532.4179.24.camel@localhost.localdomain>
On Sunday 03 August 2008 12:02:12 pm James Bottomley wrote:
> +static void pci_note_irq_problem(struct pci_dev *pdev, const char *reason)
> +{
> + struct pci_dev *parent = to_pci_dev(pdev->dev.parent);
> +
> + dev_printk(KERN_ERR, &pdev->dev,
> + "Potentially misrouted IRQ (Bridge %s %04x:%04x)\n",
> + parent->dev.bus_id, parent->vendor, parent->device);
Do you prefer "dev_printk(KERN_ERR, ...)" over "dev_err(...)"? Easier
to grep for the former, maybe? If so, should we deprecate "dev_err()"
and friends? When I converted most of the PCI core to use dev_printk(),
(80ccba1186d48f ...) I used dev_err(), but I don't really care one way
or the other.
Maybe use pci_name(parent)?
I tried to standardize the PCI core on "[%04x/%04x]" for vendor/device ID.
Bjorn
next prev parent reply other threads:[~2008-08-04 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 18:02 [PATCH 1/2] pci: add misrouted interrupt error handling James Bottomley
2008-08-04 2:51 ` Matthew Wilcox
2008-08-04 3:46 ` James Bottomley
2008-08-04 4:30 ` Grant Grundler
2008-08-04 13:31 ` James Bottomley
2008-08-04 20:43 ` Bjorn Helgaas [this message]
2008-08-04 21:35 ` Matthew Wilcox
2008-08-04 22:20 ` Bjorn Helgaas
2008-08-05 0:02 ` James Bottomley
2008-08-05 15:42 ` Bjorn Helgaas
2008-08-05 17:03 ` Jesse Barnes
2008-08-05 20:44 ` James Bottomley
2008-08-05 20:53 ` Jesse Barnes
2008-08-05 20:56 ` James Bottomley
2008-08-05 21:15 ` Jesse Barnes
2008-08-05 21:54 ` James Bottomley
2008-08-07 16:03 ` Jesse Barnes
2008-08-07 17:20 ` Greg KH
2008-08-07 17:36 ` James Bottomley
2008-10-23 21:55 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808041443.20942.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox