[PATCH] Fixup KERN_INFO in tmscsim.c

[PATCH] Fixup KERN_INFO in tmscsim.c

[Nick Warne]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi all,

Setting up my new AMD64 I noticed a curious one liner in syslogs:

^Iwith "disable_clustering=1" and report to maintainers

The attached patch fixes this up so he goes back to his wife
in /var/log/messages (or wherever KERN_INFO logs on the system):


DC390: clustering now enabled by default. If you get problems load
with "disable_clustering=1" and report to maintainers


The patch was created on stable 2.6.26.2 git tree.

Nick

Signed off by: "Nick Warne" <nick@ukfsn.org>
-- 
Free Software Foundation Associate Member 5508

[-- Attachment #2: tmscsim_warn.patch --]
[-- Type: text/x-patch, Size: 631 bytes --]

--- drivers/scsi/tmscsim.cORIG	2008-08-15 10:30:47.000000000 +0100
+++ drivers/scsi/tmscsim.c	2008-08-15 11:45:01.000000000 +0100
@@ -2573,8 +2573,8 @@
 static int __init dc390_module_init(void)
 {
 	if (!disable_clustering)
-		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
-		       "\twith \"disable_clustering=1\" and report to maintainers\n");
+		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+		printk(KERN_INFO "with \"disable_clustering=1\" and report to maintainers\n");
 
 	if (tmscsim[0] == -1 || tmscsim[0] > 15) {
 		tmscsim[0] = 7;

Re: [PATCH] Fixup KERN_INFO in tmscsim.c

[Guennadi Liakhovetski]

On Fri, 15 Aug 2008, Nick Warne wrote:

> Setting up my new AMD64 I noticed a curious one liner in syslogs:

Wow, are you sure you need the tmscsim driver on your new amd64 system?:-)

> ^Iwith "disable_clustering=1" and report to maintainers

The message priority is indeed missing in the second line, but it has 
nothing to do with the "^I" in your log. I do not know why your syslogd / 
klogd converts a TAB to "^I". But if it is a problem, I think, the correct 
fix would be something like

-		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
-		       "\twith \"disable_clustering=1\" and report to maintainers\n");
+		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+		printk(KERN_INFO "       with \"disable_clustering=1\" and report to maintainers\n");

Or maybe just remove that printk altogether - it has been there for almost 
2 years now, and I haven't heard a single complaint, but on the other 
hand, maybe you are the first, who at least loaded this driver since 2 
years:-)

Ok, taking into account that this driver is hardly used, I would keep this 
warning in case someone does get a problem.

So, please, redo as above, create with "-p1" format, fix your Sob line

> Signed off by: "Nick Warne" <nick@ukfsn.org>

which has to be

Signed-off-by: Nick Warne <nick@ukfsn.org>

and send the patch inline,

Thanks
Guennadi
---
Guennadi Liakhovetski

Re: [PATCH] Fixup KERN_INFO in tmscsim.c

[Nick Warne]

On Fri, 15 Aug 2008 22:17:57 +0200 (CEST)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

> On Fri, 15 Aug 2008, Nick Warne wrote:
> Wow, are you sure you need the tmscsim driver on your new amd64
> system?:-)

I don't know :-)  A new distro (Slackware 12.1) has almost everything
set as modules, so I am currently building new kernel removing them as I
go - just the first couple of log scans revealed this...

> I do not know why your
> syslogd / klogd converts a TAB to "^I". 

Mystery to me too...

> So, please, redo as above, create with "-p1" format, fix your Sob line

Thanks.

Nick

New patch attached.

Signed off by: Nick Warne nick@ukfsn.org

--- linux-2.6.26.y/drivers/scsi/tmscsim.cORIG	2008-08-15 10:30:47.000000000 +0100
+++ linux-2.6.26.y/drivers/scsi/tmscsim.c	2008-08-16 08:45:43.000000000 +0100
@@ -2573,8 +2573,8 @@
 static int __init dc390_module_init(void)
 {
 	if (!disable_clustering)
-		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
-		       "\twith \"disable_clustering=1\" and report to maintainers\n");
+		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+		printk(KERN_INFO "	with \"disable_clustering=1\" and report to maintainers\n");
 
 	if (tmscsim[0] == -1 || tmscsim[0] > 15) {
 		tmscsim[0] = 7;


-- 
Free Software Foundation Associate Member 5508

[PATCH] Fixup KERN_INFO in tmscsim.c

[Guennadi Liakhovetski]

From: Nick Warne <nick@ukfsn.org>

Multiline kernel messages should contain a priority in every line, 
besides, some log daemons represent a tabulator as "^I", fix both these 
issues.

Signed-off-by: Nick Warne <nick@ukfsn.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

---

On Sat, 16 Aug 2008, Nick Warne wrote:

> On Fri, 15 Aug 2008 22:17:57 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> 
> > So, please, redo as above, create with "-p1" format, fix your Sob line
> 
> New patch attached.

Nick, I took the liberty to reformat your Sob and to replace the tab in 
your patch with spaces - as was in my previous reply to you. Hope, you 
don't mind:-)

diff -u linux-2.6.26.y/drivers/scsi/tmscsim.cORIG linux-2.6.26.y/drivers/scsi/tmscsim.c
--- linux-2.6.26.y/drivers/scsi/tmscsim.cORIG	2008-08-15 10:30:47.000000000 +0100
+++ linux-2.6.26.y/drivers/scsi/tmscsim.c	2008-08-16 08:45:43.000000000 +0100
@@ -2573,8 +2573,8 @@
 static int __init dc390_module_init(void)
 {
 	if (!disable_clustering)
-		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
-		       "\twith \"disable_clustering=1\" and report to maintainers\n");
+		printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+		printk(KERN_INFO "       with \"disable_clustering=1\" and report to maintainers\n");
 
 	if (tmscsim[0] == -1 || tmscsim[0] > 15) {
 		tmscsim[0] = 7;

Re: [PATCH] Fixup KERN_INFO in tmscsim.c

[Nick Warne]

Hi Guennadi,

On Sun, 17 Aug 2008 00:00:44 +0200 (CEST)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

> From: Nick Warne <nick@ukfsn.org>
> 
> Multiline kernel messages should contain a priority in every line, 
> besides, some log daemons represent a tabulator as "^I", fix both
> these issues.
> 
> Signed-off-by: Nick Warne <nick@ukfsn.org>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

> Nick, I took the liberty to reformat your Sob and to replace the tab
> in your patch with spaces - as was in my previous reply to you. Hope,
> you don't mind:-)

No not at all - I saw just as I clicked *send* I buggered up the
Signed-off-by line... and also I didn't realise they was spaces - I
thought you changed to a real whitespace TAB rather than \t (but I
guess there is no difference on the way the lines get parsed).

Anyway, as an aside, my syslogd/klogd still shows whitespace TAB as ^I,
so I haven't clue what if going on there.

Also, now I have trimmed up my kernel build for new box, I don't see
these drivers anyway now... but at least it was caught.

Nick

> diff -u linux-2.6.26.y/drivers/scsi/tmscsim.cORIG
> linux-2.6.26.y/drivers/scsi/tmscsim.c ---
> linux-2.6.26.y/drivers/scsi/tmscsim.cORIG	2008-08-15
> 10:30:47.000000000 +0100 +++
> linux-2.6.26.y/drivers/scsi/tmscsim.c	2008-08-16
> 08:45:43.000000000 +0100 @@ -2573,8 +2573,8 @@ static int __init
> dc390_module_init(void) { if (!disable_clustering)
> -		printk(KERN_INFO "DC390: clustering now enabled by
> default. If you get problems load\n"
> -		       "\twith \"disable_clustering=1\" and report
> to maintainers\n");
> +		printk(KERN_INFO "DC390: clustering now enabled by
> default. If you get problems load\n");
> +		printk(KERN_INFO "       with
> \"disable_clustering=1\" and report to maintainers\n"); 
>  	if (tmscsim[0] == -1 || tmscsim[0] > 15) {
>  		tmscsim[0] = 7;
> 


-- 
Free Software Foundation Associate Member 5508