From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: ConfigFS + Target Mode Engine API discussion Date: Wed, 10 Sep 2008 19:13:31 -0700 Message-ID: <20080911021331.GA12902@mail.oracle.com> References: <1221087547.27831.165.camel@haakon2.linux-iscsi.org> <20080910233107.GC23864@mail.oracle.com> <1221097366.27831.216.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:62053 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754984AbYIKCPf (ORCPT ); Wed, 10 Sep 2008 22:15:35 -0400 Content-Disposition: inline In-Reply-To: <1221097366.27831.216.camel@haakon2.linux-iscsi.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Nicholas A. Bellinger" Cc: "Linux-iSCSI.org Target Dev" , linux-scsi , SCST-Devel On Wed, Sep 10, 2008 at 06:42:46PM -0700, Nicholas A. Bellinger wrote: > So I am thinking about the following question: What would be the > preferred method for calling ct_group_ops->make_group() in order to > create the $CONFIGFS/target/$FABRIC struct config_item directly from > target_fabric_configfs_register() call? From there, the config group > hanging off $CONFIGFS/target/$FABRIC will be fabric dependent and > providing their own groups, items, depends, from the passed *fabric_cit. > How do I "simulate" a mkdir(2) configfs -> make_group() call coming from > the fabric module itself..? This would be assuming that both mkdir(2) That's precisely what you don't do with configfs. It's a defined "not to be done" thing. So there's no preferred way, there's no way at all. What you want do to is drive this from mkdir(). The make_group() will look up the sub-module it needs and return the appropriate item. Joel -- "The lawgiver, of all beings, most owes the law allegiance. He of all men should behave as though the law compelled him. But it is the universal weakness of mankind that what we are given to administer we presently imagine we own." - H.G. Wells Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127