From: Martin Michlmayr <tbm@cyrius.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Disable advansys on ARM and MIPS
Date: Thu, 2 Oct 2008 09:49:15 +0200 [thread overview]
Message-ID: <20081002074915.GA13602@deprecation.cyrius.com> (raw)
In-Reply-To: <20080930161259.GA13822@parisc-linux.org>
* Matthew Wilcox <matthew@wil.cx> [2008-09-30 10:13]:
> > Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
> > work on parisc") removed the "depends on BROKEN || X86_32" line from
> > advansys' Kconfig entry. Unfortunately, this led to compilation errors
> > on ARM and MIPS (that are not related). Since nobody looked into this
> > issue since I reported it in January 2008 and Russell King said that
> > the driver is completely broken on ARM, let's undo some of the damage
> > caused by the removal of the "BROKEN" Kconfig depends by disabling the
> > driver on ARM and MIPS.
>
> Huh? I've looked into it. ARM and MIPS provide half of an API but not
> the other half. These architectures are broken.
Maybe, but the point is that advansys was marked as BROKEN on !X86_32
before and now it's not, so the ARM/MIPS compilation errors show up
and that's a regression. What you say is a good argument for my patch
to disable advansys for ARM/MIPS in Kconfig.
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2008-10-02 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 7:23 [PATCH] scsi: Disable advansys on ARM and MIPS Martin Michlmayr
2008-09-30 7:34 ` Christoph Hellwig
2008-09-30 11:31 ` Martin Michlmayr
2008-09-30 16:13 ` Matthew Wilcox
2008-10-02 7:49 ` Martin Michlmayr [this message]
2008-10-02 11:24 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002074915.GA13602@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox