* [PATCH] scsi: Disable advansys on ARM and MIPS
@ 2008-09-30 7:23 Martin Michlmayr
2008-09-30 7:34 ` Christoph Hellwig
2008-09-30 16:13 ` Matthew Wilcox
0 siblings, 2 replies; 6+ messages in thread
From: Martin Michlmayr @ 2008-09-30 7:23 UTC (permalink / raw)
To: linux-scsi
Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
work on parisc") removed the "depends on BROKEN || X86_32" line from
advansys' Kconfig entry. Unfortunately, this led to compilation errors
on ARM and MIPS (that are not related). Since nobody looked into this
issue since I reported it in January 2008 and Russell King said that
the driver is completely broken on ARM, let's undo some of the damage
caused by the removal of the "BROKEN" Kconfig depends by disabling the
driver on ARM and MIPS.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
--- a/drivers/scsi/Kconfig 2007-12-27 19:16:18.000000000 +0000
+++ b/drivers/scsi/Kconfig 2007-12-27 19:16:58.000000000 +0000
@@ -523,6 +523,7 @@
tristate "AdvanSys SCSI support"
depends on SCSI && VIRT_TO_BUS
depends on ISA || EISA || PCI
+ depends on (!MIPS && !ARM) || BROKEN
help
This is a driver for all SCSI host adapters manufactured by
AdvanSys. It is documented in the kernel source in
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: Disable advansys on ARM and MIPS
2008-09-30 7:23 [PATCH] scsi: Disable advansys on ARM and MIPS Martin Michlmayr
@ 2008-09-30 7:34 ` Christoph Hellwig
2008-09-30 11:31 ` Martin Michlmayr
2008-09-30 16:13 ` Matthew Wilcox
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2008-09-30 7:34 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: linux-scsi
On Tue, Sep 30, 2008 at 10:23:54AM +0300, Martin Michlmayr wrote:
> Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
> work on parisc") removed the "depends on BROKEN || X86_32" line from
> advansys' Kconfig entry. Unfortunately, this led to compilation errors
> on ARM and MIPS (that are not related). Since nobody looked into this
> issue since I reported it in January 2008 and Russell King said that
> the driver is completely broken on ARM, let's undo some of the damage
> caused by the removal of the "BROKEN" Kconfig depends by disabling the
> driver on ARM and MIPS.
I'd still call it broken everywhere. People who really care about this
driver should just help with the full dma api translation, if only by
testing patches.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: Disable advansys on ARM and MIPS
2008-09-30 7:34 ` Christoph Hellwig
@ 2008-09-30 11:31 ` Martin Michlmayr
0 siblings, 0 replies; 6+ messages in thread
From: Martin Michlmayr @ 2008-09-30 11:31 UTC (permalink / raw)
To: linux-scsi
* Christoph Hellwig <hch@infradead.org> [2008-09-30 03:34]:
> I'd still call it broken everywhere. People who really care about this
> driver should just help with the full dma api translation, if only by
> testing patches.
I don't have the hardware or care about the driver, but I care about
the compilation errors on ARM and MIPS that were not there before
willy's patch. Anyway, since you say it's broken, how about putting
back in the original Kconfig depends and add parisc to the list.
I don't care which patch goes in, as long as the compilation error
goes away.
From: Martin Michlmayr <tbm@cyrius.com>
Subject: [PATCH] scsi: Enable advansys on x86_32 and parisc only
Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
work on parisc") removed the "depends on BROKEN || X86_32" line from
the advansys Kconfig entry. Unfortunately, this led to compilation
errors on ARM and MIPS (that are not related). Nobody looked into this
issue since I reported it in January 2008, but Russell King said that
the driver is completely broken on ARM, and Christoph Hellwig
calls it "broken everywhere". So let's put in the original depends on
BROKEN and make the driver available on x86_32 and parisc.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -520,6 +520,7 @@ config SCSI_ADVANSYS
tristate "AdvanSys SCSI support"
depends on SCSI && VIRT_TO_BUS
depends on ISA || EISA || PCI
+ depends on BROKEN || X86_32 || PARISC
help
This is a driver for all SCSI host adapters manufactured by
AdvanSys. It is documented in the kernel source in
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: Disable advansys on ARM and MIPS
2008-09-30 7:23 [PATCH] scsi: Disable advansys on ARM and MIPS Martin Michlmayr
2008-09-30 7:34 ` Christoph Hellwig
@ 2008-09-30 16:13 ` Matthew Wilcox
2008-10-02 7:49 ` Martin Michlmayr
1 sibling, 1 reply; 6+ messages in thread
From: Matthew Wilcox @ 2008-09-30 16:13 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: linux-scsi
On Tue, Sep 30, 2008 at 10:23:54AM +0300, Martin Michlmayr wrote:
> Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
> work on parisc") removed the "depends on BROKEN || X86_32" line from
> advansys' Kconfig entry. Unfortunately, this led to compilation errors
> on ARM and MIPS (that are not related). Since nobody looked into this
> issue since I reported it in January 2008 and Russell King said that
> the driver is completely broken on ARM, let's undo some of the damage
> caused by the removal of the "BROKEN" Kconfig depends by disabling the
> driver on ARM and MIPS.
Huh? I've looked into it. ARM and MIPS provide half of an API but not
the other half. These architectures are broken.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: Disable advansys on ARM and MIPS
2008-09-30 16:13 ` Matthew Wilcox
@ 2008-10-02 7:49 ` Martin Michlmayr
2008-10-02 11:24 ` Matthew Wilcox
0 siblings, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2008-10-02 7:49 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-scsi
* Matthew Wilcox <matthew@wil.cx> [2008-09-30 10:13]:
> > Commit 9d511a4b29de6764931343d03e493f2e04df0271 ("advansys: Changes to
> > work on parisc") removed the "depends on BROKEN || X86_32" line from
> > advansys' Kconfig entry. Unfortunately, this led to compilation errors
> > on ARM and MIPS (that are not related). Since nobody looked into this
> > issue since I reported it in January 2008 and Russell King said that
> > the driver is completely broken on ARM, let's undo some of the damage
> > caused by the removal of the "BROKEN" Kconfig depends by disabling the
> > driver on ARM and MIPS.
>
> Huh? I've looked into it. ARM and MIPS provide half of an API but not
> the other half. These architectures are broken.
Maybe, but the point is that advansys was marked as BROKEN on !X86_32
before and now it's not, so the ARM/MIPS compilation errors show up
and that's a regression. What you say is a good argument for my patch
to disable advansys for ARM/MIPS in Kconfig.
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: Disable advansys on ARM and MIPS
2008-10-02 7:49 ` Martin Michlmayr
@ 2008-10-02 11:24 ` Matthew Wilcox
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Wilcox @ 2008-10-02 11:24 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: linux-scsi
On Thu, Oct 02, 2008 at 09:49:15AM +0200, Martin Michlmayr wrote:
> * Matthew Wilcox <matthew@wil.cx> [2008-09-30 10:13]:
> > Huh? I've looked into it. ARM and MIPS provide half of an API but not
> > the other half. These architectures are broken.
>
> Maybe, but the point is that advansys was marked as BROKEN on !X86_32
> before and now it's not, so the ARM/MIPS compilation errors show up
> and that's a regression. What you say is a good argument for my patch
> to disable advansys for ARM/MIPS in Kconfig.
No, ARM and MIPS need to just add stub functions that do nothing.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-10-02 11:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-30 7:23 [PATCH] scsi: Disable advansys on ARM and MIPS Martin Michlmayr
2008-09-30 7:34 ` Christoph Hellwig
2008-09-30 11:31 ` Martin Michlmayr
2008-09-30 16:13 ` Matthew Wilcox
2008-10-02 7:49 ` Martin Michlmayr
2008-10-02 11:24 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox