Re: [lm-sensors] [PATCH 06/12] adt7470: Load automatically on IntelliStation Z30 via DMI

[Jean Delvare <khali@linux-fr.org>]

Hi Darrick,

On Mon, 06 Oct 2008 18:18:54 -0700, Darrick J. Wong wrote:
> 
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> ---
> 
>  drivers/hwmon/adt7470.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c
> index 656bf3d..ef26014 100644
> --- a/drivers/hwmon/adt7470.c
> +++ b/drivers/hwmon/adt7470.c
> @@ -1114,3 +1114,6 @@ MODULE_LICENSE("GPL");
>  
>  module_init(adt7470_init);
>  module_exit(adt7470_exit);
> +
> +MODULE_ALIAS("dmi:bvnIBM:*:rn9228:*");
> +MODULE_ALIAS("dmi:bvnIBM:*:rn9232:*");

Nack. We have a user-space script to detect hardware monitoring chips
and load the corresponding drivers. We aren't going to add 2000+
DMI-based module aliases to handle all motherboards out there in the
kernel directly, this simply doesn't scale. And you need some
user-space configuration in almost all cases, so even DMI-based module
aliases wouldn't give you an automatic setup.

On top of that, in cases where detection doesn't work, there are better
ways to instantiate specific I2C devices now.

-- 
Jean Delvare