From: Jean Delvare <khali@linux-fr.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-scsi@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets
Date: Wed, 8 Oct 2008 13:13:02 +0200 [thread overview]
Message-ID: <20081008131302.5dfd4bb4@hyperion.delvare> (raw)
In-Reply-To: <20081007011904.12701.37660.stgit@elm3a70.beaverton.ibm.com>
Hi Darrick,
On Mon, 06 Oct 2008 18:19:04 -0700, Darrick J. Wong wrote:
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> ---
>
> drivers/hwmon/i5k_amb.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
> index 2ede938..bf153ae 100644
> --- a/drivers/hwmon/i5k_amb.c
> +++ b/drivers/hwmon/i5k_amb.c
> @@ -605,3 +605,6 @@ MODULE_LICENSE("GPL");
>
> module_init(i5k_amb_init);
> module_exit(i5k_amb_exit);
> +
> +MODULE_ALIAS("pci:v00008086d000025F0sv*sd*bc*sc*i*");
> +MODULE_ALIAS("pci:v00008086d00004030sv*sd*bc*sc*i*");
This looks wrong to me. If these PCI devices provide the feature this
driver supports, then why is this a platform driver and not a PCI
driver? You would get the right module aliases for free.
--
Jean Delvare
next prev parent reply other threads:[~2008-10-08 11:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 1:18 [PATCH 00/12] Various hwmon patches Darrick J. Wong
2008-10-07 1:18 ` [PATCH 01/12] hwmon: Define sysfs interface for energy consumption register Darrick J. Wong
2008-10-08 8:09 ` [lm-sensors] " Jean Delvare
2008-10-07 1:18 ` [PATCH 02/12] adt7462: New hwmon driver Darrick J. Wong
2008-10-07 1:18 ` [PATCH 03/12] adt7473: Fix some bogosity in documentation file Darrick J. Wong
2008-10-08 9:08 ` [lm-sensors] " Jean Delvare
2008-10-07 1:18 ` [PATCH 04/12] adt7470: Fix pwm*-auto-point* to be temp*-auto-point* Darrick J. Wong
2008-10-08 9:25 ` [lm-sensors] " Jean Delvare
2008-10-07 1:18 ` [PATCH 05/12] adt7470: Add documentation Darrick J. Wong
2008-10-08 9:46 ` [lm-sensors] " Jean Delvare
2008-10-07 1:18 ` [PATCH 06/12] adt7470: Load automatically on IntelliStation Z30 via DMI Darrick J. Wong
2008-10-08 11:08 ` [lm-sensors] " Jean Delvare
2008-10-07 1:18 ` [PATCH 07/12] ics932s401: New driver Darrick J. Wong
2008-10-08 11:09 ` [lm-sensors] " Jean Delvare
2008-10-07 1:19 ` [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets Darrick J. Wong
2008-10-08 11:13 ` Jean Delvare [this message]
2008-10-07 1:19 ` [PATCH 09/12] ibmpex: Automatically load on IBM systems via DMI Darrick J. Wong
2008-10-08 12:01 ` [lm-sensors] " Jean Delvare
2008-10-08 14:33 ` Christian Krafft
2008-10-07 1:19 ` [PATCH 10/12] ibmaem: " Darrick J. Wong
2008-10-07 1:19 ` [PATCH 11/12] adt7470: Check input range when sysfs files are written Darrick J. Wong
2008-10-07 1:19 ` [PATCH 12/12] adt7473: Check inputs from sysfs writes Darrick J. Wong
2008-10-07 1:27 ` [PATCH 00/12] Various hwmon patches Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008131302.5dfd4bb4@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox