From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets Date: Wed, 8 Oct 2008 13:13:02 +0200 Message-ID: <20081008131302.5dfd4bb4@hyperion.delvare> References: <20081007011824.12701.39532.stgit@elm3a70.beaverton.ibm.com> <20081007011904.12701.37660.stgit@elm3a70.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from zone0.gcu-squad.org ([212.85.147.21]:11702 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbYJHLNS (ORCPT ); Wed, 8 Oct 2008 07:13:18 -0400 In-Reply-To: <20081007011904.12701.37660.stgit@elm3a70.beaverton.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Darrick J. Wong" Cc: Andrew Morton , linux-kernel , lm-sensors Hi Darrick, On Mon, 06 Oct 2008 18:19:04 -0700, Darrick J. Wong wrote: > > Signed-off-by: Darrick J. Wong > --- > > drivers/hwmon/i5k_amb.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c > index 2ede938..bf153ae 100644 > --- a/drivers/hwmon/i5k_amb.c > +++ b/drivers/hwmon/i5k_amb.c > @@ -605,3 +605,6 @@ MODULE_LICENSE("GPL"); > > module_init(i5k_amb_init); > module_exit(i5k_amb_exit); > + > +MODULE_ALIAS("pci:v00008086d000025F0sv*sd*bc*sc*i*"); > +MODULE_ALIAS("pci:v00008086d00004030sv*sd*bc*sc*i*"); This looks wrong to me. If these PCI devices provide the feature this driver supports, then why is this a platform driver and not a PCI driver? You would get the right module aliases for free. -- Jean Delvare