From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Krafft Subject: Re: [lm-sensors] [PATCH 09/12] ibmpex: Automatically load on IBM systems via DMI Date: Wed, 8 Oct 2008 16:33:14 +0200 Message-ID: <20081008163314.53dcadd3@schleppi> References: <20081007011824.12701.39532.stgit@elm3a70.beaverton.ibm.com> <20081007011909.12701.96969.stgit@elm3a70.beaverton.ibm.com> <20081008140158.5a2e1184@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mtagate3.uk.ibm.com ([195.212.29.136]:40566 "EHLO mtagate3.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbYJHOdV (ORCPT ); Wed, 8 Oct 2008 10:33:21 -0400 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate3.uk.ibm.com (8.13.8/8.13.8) with ESMTP id m98EXJ76132170 for ; Wed, 8 Oct 2008 14:33:19 GMT Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m98EXHkl1917064 for ; Wed, 8 Oct 2008 15:33:17 +0100 Received: from d06av03.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m98EXGdH004242 for ; Wed, 8 Oct 2008 15:33:16 +0100 In-Reply-To: <20081008140158.5a2e1184@hyperion.delvare> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jean Delvare Cc: "Darrick J. Wong" , Andrew Morton , linux-kernel , lm-sensors Hi, On Wed, 8 Oct 2008 14:01:58 +0200 Jean Delvare wrote: > Hi Darrick, > > On Mon, 06 Oct 2008 18:19:09 -0700, Darrick J. Wong wrote: > > > > Signed-off-by: Darrick J. Wong > > --- > > > > drivers/hwmon/ibmpex.c | 6 ++++++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c > > index 4e9b19c..6e3a2c4 100644 > > --- a/drivers/hwmon/ibmpex.c > > +++ b/drivers/hwmon/ibmpex.c > > @@ -608,3 +608,9 @@ MODULE_LICENSE("GPL"); > > > > module_init(ibmpex_init); > > module_exit(ibmpex_exit); > > + > > +MODULE_ALIAS("dmi:bvnIBM:*:pnIBMSystemx3650*"); > > +MODULE_ALIAS("dmi:bvnIBM:*:pnIBMSystemx3550*"); > > +MODULE_ALIAS("dmi:bvnIBM:*:pnIBMSystemx3655*"); > > +MODULE_ALIAS("dmi:bvnIBM:*:pnIBMSystemx3755*"); > > +MODULE_ALIAS("dmi:bvnIBM:*:pnIBMSystemx3350*"); > > Is there no way to have an alias at the IPMI level? That is, alias on > the device itself rather than the systems it is in? This would avoid the > foreseeable requirement to add entries every time new machines are > released. First foreseeable requirement would come from my side. IBM's cell blades QS21/QS22 also support AEM/PEX. On Power we don't have DMI information, but a slof device tree. One could also add the open firmware path to the ipmi device. But to avoid autoloading on other slof based machines with ipmi one would have to add compatible attributes for each machine. So autoloading based on available ipmi sensors would be much better. > > But if there is no such way then I am fine applying this patch (except > that I'd sort the entries). I also suspect that the last "*" should > actually be ":*"? > -- Mit freundlichen Gruessen, kind regards, Christian Krafft Linux Kernel Development IBM Systems & Technology Group Phone: +49-07031-16-2032 IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaetsfuehung: Herbert Kircher Sitz der Gesellschaft: Boelingen Registergericht: Amtsgericht Stuttgart, HRB 243294