Re: LSISAS1068 ioerr_cnt 0x1 on clean boot up

[Abhijit Paithankar <apaithan@akamai.com>]

* Moore, Eric (Eric.Moore@lsi.com) wrote:
> Abhijit - You're patch would allow page 0x19 to STP devices, which I doubt is supported either.     I think you should be doing the following instead:
> 
> +       if (rphy->identify.device_type == SAS_END_DEVICE &&
> +          (rphy->identify.target_port_protocols & SAS_PROTOCOL_SSP))
> +               sas_read_port_mode_page(sdev);

Yes, thanks for pointing that out. I think it needs to be OR-ed with
SAS_PROTOCOL_SATA.

Here is the updated patch.

Signed-off-by: Abhijit Paithankar <apaitha@akamai.com>

Index: linux-2.6.27/drivers/message/fusion/mptsas.c
===================================================================
--- linux-2.6.27.orig/drivers/message/fusion/mptsas.c	2008-10-13 17:31:57.000000000 -0700
+++ linux-2.6.27/drivers/message/fusion/mptsas.c	2008-10-13 19:51:57.000000000 -0700
@@ -839,11 +839,15 @@ mptsas_sas_enclosure_pg0(MPT_ADAPTER *io
 static int
 mptsas_slave_configure(struct scsi_device *sdev)
 {
+	struct sas_rphy *rphy;
 
 	if (sdev->channel == MPTSAS_RAID_CHANNEL)
 		goto out;
 
-	sas_read_port_mode_page(sdev);
+	rphy = dev_to_rphy(sdev->sdev_target->dev.parent);
+	if (rphy->identify.device_type == SAS_END_DEVICE &&
+	   !(rphy->identify.target_port_protocols & (SAS_PROTOCOL_SATA | SAS_PROTOCOL_SSP)))
+		sas_read_port_mode_page(sdev);
 
  out:
 	return mptscsih_slave_configure(sdev);