From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [Bug 11800] New: building SES support fails w/ gcc-3.4.5 Date: Wed, 22 Oct 2008 13:30:46 -0700 Message-ID: <20081022133046.0fa7de8a.akpm@linux-foundation.org> References: <20081021155240.851b69c3.akpm@linux-foundation.org> <200810221943.m9MJh8bR031381@colby.verdasys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:48460 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754439AbYJVUb5 (ORCPT ); Wed, 22 Oct 2008 16:31:57 -0400 In-Reply-To: <200810221943.m9MJh8bR031381@colby.verdasys.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Marc Bejarano Cc: bugme-daemon@bugzilla.kernel.org, linux-scsi@vger.kernel.org On Wed, 22 Oct 2008 15:43:05 -0400 Marc Bejarano wrote: > At 18:52 10/21/2008, Andrew Morton wrote: > >On Tue, 21 Oct 2008 11:36:12 -0700 (PDT) > >bugme-daemon@bugzilla.kernel.org wrote: > > > >> http://bugzilla.kernel.org/show_bug.cgi?id=11800 > >> > >> Summary: building SES support fails w/ gcc-3.4.5 > >> Product: SCSI Drivers > >> Version: 2.5 > >> KernelVersion: 2.6.27.1 > >> Platform: All > >> OS/Version: Linux > >> Tree: Mainline > >> Status: NEW > >> Severity: normal > >> Priority: P1 > >> Component: Other > >> AssignedTo: scsi_drivers-other@kernel-bugs.osdl.org > >> ReportedBy: bugzilla.kernel.org@beej.org > >> > >> > >> [beej@dell ~]$ cat /etc/redhat-release > >> CentOS release 4.3 (Final) > >> [beej@dell ~]$ rpm -qf `which gcc` > >> gcc-3.4.5-2 > >> [beej@dell linux-2.6.27.1]$ diff .config .config.old > >> 4c4 > >> < # Tue Oct 21 14:07:00 2008 > >> --- > >> > # Thu Oct 16 17:54:42 2008 > >> 1006c1006 > >> < # CONFIG_SCSI_ENCLOSURE is not set > >> --- > >> > CONFIG_SCSI_ENCLOSURE=m > >> > >> using .config.old, > >> [beej@dell linux-2.6.27.1]$ make > >> > >> Kernel: arch/x86/boot/bzImage is ready (#2) > >> Building modules, stage 2. > >> MODPOST 668 modules > >> ERROR: "__you_cannot_kmalloc_that_much" [drivers/scsi/ses.ko] undefined! > >> make[1]: *** [__modpost] Error 1 > >> make: *** [modules] Error 2 > >> > > > >That's weird. It means that we did a kmalloc(N, ...) where the value > >of N is known at compile time, and N is too large. > > > >But I can find no such kmalloc/kzalloc calls in ses.c. It might be gcc > >bustage - we've seen that before. > > > >Please do > > > > make drivers/scsi/ses.s > > > >then have a look in drivers/scsi/ses.s and see which function is > >emitting a call to __you_cannot_kmalloc_that_much. Or email me > >drivers/scsi/ses.s and I'll take a look. > > attached > OK, it's here: buf = kmalloc(vpd_len, GFP_KERNEL); it's a gcc bug. Please see if you can find some way to make it go away - perhaps change vpd_len's type to `int', things like that. Or use a different compiler version :(