[PATCH 1/2] cciss: fix sysfs broken symlink regression

[PATCH 1/2] cciss: fix sysfs broken symlink regression

[Mike Miller]

Patch 1 of 2

Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40.
This patch fixes a broken symlink in sysfs that was introduced by the above
commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc
on or about 20080804. Some installers are broken if this symlink does not
exist and they may not detect the logical drives configured on the
controller.
It does not require being backported into 2.6.26.x or earlier kernels.

Please consider this for inclusion.

Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?

Signed-off-by: Mike Miller <mike.miller@hp.com>

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 1e1f915..0f367b1 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 	disk->first_minor = drv_index << NWD_SHIFT;
 	disk->fops = &cciss_fops;
 	disk->private_data = &h->drv[drv_index];
+	disk->driverfs_dev = &h->pdev->dev;
 
 	/* Set up queue information */
 	blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);

Re: [PATCH 1/2] cciss: fix sysfs broken symlink regression

[Andrew Morton]

On Mon, 27 Oct 2008 16:01:36 -0500
Mike Miller <mike.miller@hp.com> wrote:

> Patch 1 of 2
> 
> Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40.
> This patch fixes a broken symlink in sysfs that was introduced by the above
> commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc
> on or about 20080804. Some installers are broken if this symlink does not
> exist and they may not detect the logical drives configured on the
> controller.
> It does not require being backported into 2.6.26.x or earlier kernels.

OK, thanks, I tagged it for 2.6.27.x.

> Please consider this for inclusion.
> 
> Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?
> 

What's 2 of 2?

cciss patches which I presently have queued are:

cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch
cciss-new-hardware-support.patch
cciss-fix-sysfs-broken-symlink-regression.patch

RE: [PATCH 1/2] cciss: fix sysfs broken symlink regression

[Miller, Mike (OS Dev)]

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Monday, October 27, 2008 4:30 PM
> To: Miller, Mike (OS Dev)
> Cc: jens.axboe@oracle.com; linux-kernel@vger.kernel.org;
> linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 1/2] cciss: fix sysfs broken symlink regression
>
> On Mon, 27 Oct 2008 16:01:36 -0500
> Mike Miller <mike.miller@hp.com> wrote:
>
> > Patch 1 of 2
> >
> > Regression introduced by commit
> 6ae5ce8e8d4de666f31286808d2285aa6a50fa40.
> > This patch fixes a broken symlink in sysfs that was
> introduced by the
> > above commit also called "cciss: remove redundant code." We
> broke it
> > in 2.6.27-rc on or about 20080804. Some installers are
> broken if this
> > symlink does not exist and they may not detect the logical drives
> > configured on the controller.
> > It does not require being backported into 2.6.26.x or
> earlier kernels.
>
> OK, thanks, I tagged it for 2.6.27.x.
>
> > Please consider this for inclusion.
> >
> > Andrew, do I need to resubmit 2 of 2? Or is that one still
> in your queue?
> >
>
> What's 2 of 2?
>
> cciss patches which I presently have queued are:
>
> cciss-fix-regression-firmware-not-displayed-in-procfs-again-an
d-again.patch

This is patch 2 of 2.

> cciss-new-hardware-support.patch
> cciss-fix-sysfs-broken-symlink-regression.patch
>
>

Re: [PATCH 1/2] cciss: fix sysfs broken symlink regression

[Rafael J. Wysocki]

On Monday, 27 of October 2008, Mike Miller wrote:
> Patch 1 of 2
> 
> Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40.
> This patch fixes a broken symlink in sysfs that was introduced by the above
> commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc
> on or about 20080804. Some installers are broken if this symlink does not
> exist and they may not detect the logical drives configured on the
> controller.
> It does not require being backported into 2.6.26.x or earlier kernels.
> 
> Please consider this for inclusion.
> 
> Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?
> 
> Signed-off-by: Mike Miller <mike.miller@hp.com>
> 
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 1e1f915..0f367b1 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
>  	disk->first_minor = drv_index << NWD_SHIFT;
>  	disk->fops = &cciss_fops;
>  	disk->private_data = &h->drv[drv_index];
> +	disk->driverfs_dev = &h->pdev->dev;
>  
>  	/* Set up queue information */
>  	blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
> --

Is this a patch for bug #11404 or for another regression?

Rafael