From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mike Miller <mike.miller@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
LKML-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] cciss: fix sysfs broken symlink regression
Date: Wed, 29 Oct 2008 00:14:23 +0100 [thread overview]
Message-ID: <200810290014.24221.rjw@sisk.pl> (raw)
In-Reply-To: <20081027210136.GA9438@roadking.ldev.net>
On Monday, 27 of October 2008, Mike Miller wrote:
> Patch 1 of 2
>
> Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40.
> This patch fixes a broken symlink in sysfs that was introduced by the above
> commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc
> on or about 20080804. Some installers are broken if this symlink does not
> exist and they may not detect the logical drives configured on the
> controller.
> It does not require being backported into 2.6.26.x or earlier kernels.
>
> Please consider this for inclusion.
>
> Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?
>
> Signed-off-by: Mike Miller <mike.miller@hp.com>
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 1e1f915..0f367b1 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
> disk->first_minor = drv_index << NWD_SHIFT;
> disk->fops = &cciss_fops;
> disk->private_data = &h->drv[drv_index];
> + disk->driverfs_dev = &h->pdev->dev;
>
> /* Set up queue information */
> blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
> --
Is this a patch for bug #11404 or for another regression?
Rafael
prev parent reply other threads:[~2008-10-28 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 21:01 [PATCH 1/2] cciss: fix sysfs broken symlink regression Mike Miller
2008-10-27 21:29 ` Andrew Morton
2008-10-27 21:32 ` Miller, Mike (OS Dev)
2008-10-28 23:14 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810290014.24221.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox