From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
Swen Schillig <swen@vnet.ibm.com>
Subject: Re: [patch 3/8] zfcp: fix mempool usage for status_read requests
Date: Thu, 6 Nov 2008 16:16:11 +0100 [thread overview]
Message-ID: <20081106151611.GA3871@schmichrtp.de.ibm.com> (raw)
In-Reply-To: <1225907172.4703.45.camel@localhost.localdomain>
On Wed, Nov 05, 2008 at 12:46:12PM -0500, James Bottomley wrote:
> On Tue, 2008-11-04 at 16:35 +0100, Christof Schmitt wrote:
> > plain text document attachment (fix-status-read-alloc.diff)
> > From: Christof Schmitt <christof.schmitt@de.ibm.com>
> >
> > When allocating fsf requests without qtcb, store the pointer to the
> > mempool in the fsf requests for later call to mempool_free. This
> > codepath is only used by the status_read requests.
> >
> > Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
> > Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
>
> I put this one in, but can you explain this last signoff better? You
> sent me the patch, so your signoff should appear last. If Swen altered
> the patch, his signoff should appear before yours (with a small
> explanation of the alteration in square brackets). If he's just
> approving it, it should be Acked-by: not Signed-off-by:
I wrote the patch, Swen reviewed it and i sent it as part of the patch
series. It looks like this did not follow the exact guidelines. For
future patches, i will document the review with the "Acked-by:".
Christof
next prev parent reply other threads:[~2008-11-06 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 15:35 [patch 0/8] zfcp fixes for 2.6.28 Christof Schmitt
2008-11-04 15:35 ` [patch 1/8] zfcp: Dont clear reference from SCSI device to unit Christof Schmitt
2008-11-04 15:35 ` [patch 2/8] zfcp: fix req_list_locking Christof Schmitt
2008-11-04 15:35 ` [patch 3/8] zfcp: fix mempool usage for status_read requests Christof Schmitt
2008-11-05 17:46 ` James Bottomley
2008-11-06 15:16 ` Christof Schmitt [this message]
2008-11-04 15:35 ` [patch 4/8] zfcp: Fix request list handling in error path Christof Schmitt
2008-11-04 15:35 ` [patch 5/8] zfcp: Fix cast warning Christof Schmitt
2008-11-04 15:35 ` [patch 6/8] zfcp: Wait for port scan to complete when setting adapter online Christof Schmitt
2008-11-04 15:35 ` [patch 7/8] zfcp: fix erp timeout cleanup for port open requests Christof Schmitt
2008-11-04 15:35 ` [patch 8/8] zfcp: Fix hexdump data in s390dbf traces Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106151611.GA3871@schmichrtp.de.ibm.com \
--to=christof.schmitt@de.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=swen@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox