From: Jens Axboe <jens.axboe@oracle.com>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
scsi <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: in 2.6.23-rc3-git7 in do_cciss_intr
Date: Thu, 20 Nov 2008 18:50:30 +0100 [thread overview]
Message-ID: <20081120175029.GM26308@kernel.dk> (raw)
In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A77884EACB79F52@GVW0547EXC.americas.hpqcorp.net>
On Thu, Nov 20 2008, Miller, Mike (OS Dev) wrote:
> Jens wrote:
>
> > >
> > > I'd propose just converting it to list_head instead of doing it
> > > manually. Heck, that should be a 5 minute job, let me just do it...
> > >
> > > OK, here it is, totally untested (it compiles, must be golden...)
> >
> > It was missing a list_entry() in fail_all_cmds(), apart from
> > that it was fine. I changed it to use hlist instead, as that
> > is more appropriate and similar to how it worked before. It
> > also means there's no extra space usage in the controller
> > structure. I've tested it and it works fine for me.
> >
> > Mike, can you give this a look-over and give me a Reviewed-by
> > or similar? As an extra bonus, it also gets rid of some code.
> >
> > 3 files changed, 33 insertions(+), 46 deletions(-)
> >
> > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e303054
> > e55acd1b6478b8859a5f8648bfaf69a44
>
> That works for me. :)
>
> Acked-by: Mike Miller <mike.miller@hp.com>
Excellent, thanks Mike. If you could run it through a cycle or so of
your regular testing, I'd feel 100% confident in it.
--
Jens Axboe
next prev parent reply other threads:[~2008-11-20 17:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:52 BUG: in 2.6.23-rc3-git7 in do_cciss_intr rdunlap
2008-08-21 7:16 ` Andrew Morton
2008-08-21 14:26 ` Miller, Mike (OS Dev)
2008-08-21 15:43 ` Randy Dunlap
2008-08-21 15:48 ` Miller, Mike (OS Dev)
2008-08-21 16:15 ` Randy Dunlap
2008-08-21 16:25 ` Miller, Mike (OS Dev)
2008-08-22 0:26 ` Randy Dunlap
2008-08-22 15:48 ` Miller, Mike (OS Dev)
2008-08-22 15:54 ` James Bottomley
2008-08-22 16:49 ` Randy Dunlap
2008-08-22 17:02 ` James Bottomley
2008-08-22 18:25 ` Miller, Mike (OS Dev)
2008-09-04 16:59 ` Randy Dunlap
2008-09-04 18:00 ` Miller, Mike (OS Dev)
2008-09-05 9:28 ` Jens Axboe
2008-09-25 20:33 ` Randy Dunlap
2008-09-25 20:40 ` Randy Dunlap
2008-09-25 20:56 ` Miller, Mike (OS Dev)
2008-11-18 20:14 ` Randy Dunlap
2008-11-18 20:20 ` Randy Dunlap
2008-11-18 21:32 ` Randy Dunlap
2008-11-19 8:52 ` Jens Axboe
2008-11-19 17:00 ` Miller, Mike (OS Dev)
2008-11-19 17:22 ` Randy Dunlap
2008-11-19 17:27 ` Miller, Mike (OS Dev)
2008-11-19 17:29 ` Jens Axboe
2008-11-19 19:15 ` Miller, Mike (OS Dev)
2008-11-19 20:46 ` Jens Axboe
2008-11-20 9:13 ` Jens Axboe
2008-11-20 16:41 ` Miller, Mike (OS Dev)
2008-11-20 17:50 ` Jens Axboe [this message]
2008-11-20 19:12 ` Miller, Mike (OS Dev)
2008-11-19 17:18 ` Randy Dunlap
2008-11-18 21:32 ` Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120175029.GM26308@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Mike.Miller@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox