From: Olaf Hering <olh@suse.de>
To: linux-scsi@vger.kernel.org
Subject: oops in ibmvstgt
Date: Wed, 3 Dec 2008 15:58:57 +0100 [thread overview]
Message-ID: <20081203145857.GA10070@suse.de> (raw)
change init order to fix crash due to uninitalized shost_data
No idea if the patch is correct.
...
running with firmware 'IBM,SF235_214' on model 'IBM,9133-55A', serial 'IBM,0210C3E0D', partition 'vioserver'
...
Linux version 2.6.28-rc7-git1 (olaf@gooseberry) (gcc version 4.1.2 20070115 (SUSE Linux)) #2 SMP Wed Dec 3 14:28:31 CET 2008
...
vio_register_driver: driver ibmvscsi registering
IBM eServer i/pSeries Virtual SCSI Target Driver
vio_register_driver: driver ibmvscsis registering
scsi1 : ibmvstgt
Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc0000000002d20f4
cpu 0x0: Vector: 300 (Data Access) at [c0000001db4c7900]
pc: c0000000002d20f4: .srp_rport_add+0xb8/0x1c4
lr: c0000000002d20a8: .srp_rport_add+0x6c/0x1c4
sp: c0000001db4c7b80
msr: 8000000000009032
dar: 0
dsisr: 40000000
current = 0xc0000001de40ee80
paca = 0xc000000000753380
pid = 415, comm = ibmvtgtd/0
enter ? for help
[c0000001db4c7c30] c0000000002e3f14 .process_crq+0x2d8/0x4ec
[c0000001db4c7d00] c0000000002e4394 .handle_crq+0xac/0x270
[c0000001db4c7db0] c00000000006eec0 .run_workqueue+0x114/0x204
[c0000001db4c7e50] c0000000000700cc .worker_thread+0x118/0x138
[c0000001db4c7f00] c0000000000740bc .kthread+0x78/0xc4
[c0000001db4c7f90] c000000000028ff4 .kernel_thread+0x54/0x70
...
---
drivers/scsi/ibmvscsi/ibmvstgt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/scsi/ibmvscsi/ibmvstgt.c
+++ b/drivers/scsi/ibmvscsi/ibmvstgt.c
@@ -864,14 +864,14 @@ static int ibmvstgt_probe(struct vio_dev
INIT_WORK(&vport->crq_work, handle_crq);
- err = crq_queue_create(&vport->crq_queue, target);
- if (err)
- goto free_srp_target;
-
err = scsi_add_host(shost, target->dev);
if (err)
goto destroy_queue;
+ err = crq_queue_create(&vport->crq_queue, target);
+ if (err)
+ goto free_srp_target;
+
err = scsi_tgt_alloc_queue(shost);
if (err)
goto destroy_queue;
next reply other threads:[~2008-12-03 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 14:58 Olaf Hering [this message]
2008-12-04 12:23 ` oops in ibmvstgt FUJITA Tomonori
2008-12-05 10:53 ` Olaf Hering
2008-12-05 13:26 ` FUJITA Tomonori
2008-12-08 19:21 ` Brian King
2008-12-09 11:03 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203145857.GA10070@suse.de \
--to=olh@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).