From: Olaf Hering <olh@suse.de>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org
Subject: Re: oops in ibmvstgt
Date: Fri, 5 Dec 2008 11:53:09 +0100 [thread overview]
Message-ID: <20081205105309.GA2198@suse.de> (raw)
In-Reply-To: <20081204212414H.fujita.tomonori@lab.ntt.co.jp>
On Thu, Dec 04, FUJITA Tomonori wrote:
> On Wed, 3 Dec 2008 15:58:57 +0100
> Olaf Hering <olh@suse.de> wrote:
>
> >
> > change init order to fix crash due to uninitalized shost_data
>
> I think that calling crq_queue_create leads to the creation of a rport
> so we need to set up everything before that. The current code is racy.
>
>
> > No idea if the patch is correct.
>
> Almost correct, I think. Needs to modify the error handling
> too. Probably, it would be better to call scsi_tgt_alloc_queue before
> crq_queue_create.
>
> How about this?
Yes, that works for me.
Would be nice to get this into 2.6.28 to avoid a crash.
Olaf
next prev parent reply other threads:[~2008-12-05 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 14:58 oops in ibmvstgt Olaf Hering
2008-12-04 12:23 ` FUJITA Tomonori
2008-12-05 10:53 ` Olaf Hering [this message]
2008-12-05 13:26 ` FUJITA Tomonori
2008-12-08 19:21 ` Brian King
2008-12-09 11:03 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205105309.GA2198@suse.de \
--to=olh@suse.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).