From: Robert Jennings <rcj@linux.vnet.ibm.com>
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org,
Brian King <brking@linux.vnet.ibm.com>,
Santiago Leon <santil@us.ibm.com>
Subject: [PATCH 1/1] ibmvscsi: correct command abort logic
Date: Sat, 6 Dec 2008 09:41:39 -0600 [thread overview]
Message-ID: <20081206154139.GA13534@austin.ibm.com> (raw)
The logic is swapped when we determine if a command that we're trying
to abort has already completed. This will keep us from freeing event
structures at the correct time, fail to unmap command data properly
and throw off our request_limit count.
Signed-off-by: Robert Jennings <rcjenn@us.ibm.com>
---
ibmvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6cad175..2d9db9b 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -1099,7 +1099,7 @@ static int ibmvscsi_eh_abort_handler(struct scsi_cmnd *cmd)
}
}
- if (found_evt == NULL) {
+ if (found_evt != NULL) {
spin_unlock_irqrestore(hostdata->host->host_lock, flags);
sdev_printk(KERN_INFO, cmd->device, "aborted task tag 0x%lx completed\n",
tsk_mgmt->task_tag);
next reply other threads:[~2008-12-06 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 15:41 Robert Jennings [this message]
2008-12-08 14:32 ` [PATCH 1/1] ibmvscsi: correct command abort logic Brian King
2008-12-08 20:49 ` Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081206154139.GA13534@austin.ibm.com \
--to=rcj@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=santil@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox