From: Matthew Wilcox <matthew@wil.cx>
To: "Kashyap, Desai" <kashyap.desai@lsi.com>
Cc: linux-scsi@vger.kernel.org, eric.moore@lsi.com,
sathya.prakash@lsi.com, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch]
Date: Thu, 8 Jan 2009 07:53:04 -0700 [thread overview]
Message-ID: <20090108145303.GA6936@parisc-linux.org> (raw)
In-Reply-To: <20090108085716.GA4116@lsi.com>
On Thu, Jan 08, 2009 at 02:27:16PM +0530, Kashyap, Desai wrote:
> Added support for MSI enable/disable for different buses FC,SPI,SAS instead
> of having single MSI enable/disable feature.
Why do you think you need this?
Either the system supports MSI or it doesn't. The original reason for
only enabling MSI on SPI cards was that it reduced the number of bug
reports since FC and SAS cards are likely to be used on machines with
functional MSI.
This is of course a horrible hack. The right thing to do is to detect
that you've never received an interrupt, disable MSI, enable regular
interrupts and try again.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-01-08 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:57 [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch] Kashyap, Desai
2009-01-08 14:53 ` Matthew Wilcox [this message]
2009-01-08 15:00 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108145303.GA6936@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=eric.moore@lsi.com \
--cc=kashyap.desai@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox