From: Andrew Morton <akpm@linux-foundation.org>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [patch 10/11] scsi: fix bad use of udelay in atp870u.c
Date: Fri, 9 Jan 2009 13:03:08 -0800 [thread overview]
Message-ID: <20090109130308.bfde281e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090109205835.GB5069@deprecation.cyrius.com>
On Fri, 9 Jan 2009 21:58:35 +0100
Martin Michlmayr <tbm@cyrius.com> wrote:
> * akpm@linux-foundation.org <akpm@linux-foundation.org> [2009-01-09 12:28]:
> > The ACARD driver calls udelay() with a value > 2000, which leads to
> > to the following compilation error on ARM:
> > ERROR: "__bad_udelay" [drivers/scsi/atp870u.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > Fix this by using a combination of mdelay and udelay.
>
> James already said that this patch is wrong,
Well, it's not "wrong" - it has no runtime effect - it just fixes the build.
> so I suggest you drop
> this patch. (Even if this will probably mean that this issue will
> never get addressed.)
shrug.
next prev parent reply other threads:[~2009-01-09 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 20:28 [patch 10/11] scsi: fix bad use of udelay in atp870u.c akpm
2009-01-09 20:58 ` Martin Michlmayr
2009-01-09 21:03 ` Andrew Morton [this message]
2009-01-09 21:21 ` James Bottomley
2009-01-10 15:50 ` Christoph Hellwig
2012-04-24 7:49 ` [PATCH/RFC v2] [SCSI] atp870u: Fix bad use of udelay Jonathan Nieder
2012-04-24 21:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109130308.bfde281e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox