From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Kashyap, Desai" <kashyap.desai@lsi.com>,
linux-scsi@vger.kernel.org, eric.moore@lsi.com,
sathya.prakash@lsi.com
Subject: Re: [PATCH4/5] mpt fusion: Optimized SendEventNotification [Resendig updated patch]
Date: Sat, 10 Jan 2009 15:16:10 -0700 [thread overview]
Message-ID: <20090110221609.GG6936@parisc-linux.org> (raw)
In-Reply-To: <1231625559.3642.54.camel@localhost.localdomain>
On Sat, Jan 10, 2009 at 04:12:39PM -0600, James Bottomley wrote:
> > + dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "alt-ioc
> > + reply irq re-enabled\n",
> > + ioc->alt_ioc->name));
>
> This isn't legal C: you can't split a string constant without a
> backslash:
Umm ... I don't think you can even split it with a backslash. You need
to use string concatenation like so:
dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "alt-ioc "
"reply irq re-enabled\n",
ioc->alt_ioc->name));
Or, since it's 100% more readable and greppable:
dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT
"alt-ioc reply irq re-enabled\n",
ioc->alt_ioc->name));
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2009-01-10 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:59 [PATCH4/5] mpt fusion: Optimized SendEventNotification [Resendig updated patch] Kashyap, Desai
2009-01-10 22:12 ` James Bottomley
2009-01-10 22:16 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110221609.GG6936@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=eric.moore@lsi.com \
--cc=kashyap.desai@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).