From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH ver2 printk_ratelimit] bsg: Error print if device is not bidi capable when refusing a bidi command Date: Tue, 20 Jan 2009 15:46:08 +0100 Message-ID: <20090120144608.GQ30821@kernel.dk> References: <4975DC00.2090005@panasas.com> <20090120141517.GM30821@kernel.dk> <4975E1EE.5070101@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([93.163.65.50]:26701 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755303AbZATOrj (ORCPT ); Tue, 20 Jan 2009 09:47:39 -0500 Content-Disposition: inline In-Reply-To: <4975E1EE.5070101@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: FUJITA Tomonori , linux-scsi , open-osd mailing-list On Tue, Jan 20 2009, Boaz Harrosh wrote: > > If a bidi command was issued to a request_queue not mark as > QUEUE_FLAG_BIDI. Issue an error report. This is a misconfiguration > an administrator would like to know about, which is otherwise > hard to detect. > > Signed-off-by: Boaz Harrosh > --- > block/bsg.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/block/bsg.c b/block/bsg.c > index 44a2a0f..1da14fe 100644 > --- a/block/bsg.c > +++ b/block/bsg.c > @@ -270,6 +270,11 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm, > > if (rw == WRITE && hdr->din_xfer_len) { > if (!test_bit(QUEUE_FLAG_BIDI, &q->queue_flags)) { > + if (printk_ratelimit()) { > + printk(KERN_ERR > + "bsg: Attempt to send a bidi command " > + "to a none bidi device\n"); > + } > ret = -EOPNOTSUPP; > goto out; > } > -- > 1.6.0.1 Thanks, that works. But why isn't the -EOPNOTSUPP error return (which the app can see and print info about) enough? Do we really need to put this in the kernel log? -- Jens Axboe