public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "ed.lin" <ed.lin@promise.com>
To: James.Bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH 1/5][resend 2] stex: Fix for potential invalid request
Date: Tue, 27 Jan 2009 06:36:04 +0800	[thread overview]
Message-ID: <200901270636.04129.ed.lin@promise.com> (raw)

The interrupt routine is good for normal cases. However, if the firmware is 
abnormal and returns an invalid response, the driver may reuse a ccb 
structure that has already been handled. This may cause problem. Fix this by 
setting the req member to NULL. Next time we know the response is invalid and 
handle accordingly if req is NULL.

Signed-off-by: Ed Lin <ed.lin@promise.com>
---

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index a3a18ad..6129db4 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32 doorbell)
     stex_copy_data(ccb, resp, size);
   }
 
+  ccb->req = NULL;
   ccb->srb_status = resp->srb_status;
   ccb->scsi_status = resp->scsi_status;
 

             reply	other threads:[~2009-01-27  6:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 22:36 ed.lin [this message]
2009-01-27 15:11 ` [PATCH 1/5][resend 2] stex: Fix for potential invalid request James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901270636.04129.ed.lin@promise.com \
    --to=ed.lin@promise.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox