From: Bernd Schubert <bs@q-leap.de>
To: "Prakash, Sathya" <Sathya.Prakash@lsi.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Desai, Kashyap" <Kashyap.Desai@lsi.com>,
"Moore, Eric" <Eric.Moore@lsi.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
DL-MPT Fusion Linux <DL-MPTFusionLinux@lsi.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 sent again] introduce soft reset handler
Date: Fri, 6 Feb 2009 13:57:58 +0100 [thread overview]
Message-ID: <200902061358.00067.bs@q-leap.de> (raw)
In-Reply-To: <B73941C4DE6A3D4EA1AE128E9565E24423A0C8B613@inbmail01.lsi.com>
Sathya,
On Friday 06 February 2009 08:04:24 Prakash, Sathya wrote:
> Bernd,
> I think, there are certain other areas which needs fix up. For example you
> have added the ioc_reset_in_progress flag in the MPT_ADAPTER and used it
> instead of diagPending. But the diagPending is not removed from MPT_ADAPTER
> structure and hence there is possibility for that variable getting refered
> in other places whereas it is not getting set in the HardResetHandler So
> remove the variable from MPT_ADAPTER and solve the compile errors by
> replacing the diagPending with ioc_reset_in_progress. You can refer LSI
> code you have. Thanks
> Sathya
hmm, actually I thought diagPending and ioc_reset_in_progress are two
different issues. But so it just seems to be a renaming. So I made an extra
patch for that. I also noticed (already before), that in the your 4.x driver
it doesn check in the reset handler for ioc->alt_ioc->ioc_reset_in_progress.
Did this accidentaly happen or on purpose?
Thanks,
Bernd
--
Bernd Schubert
Q-Leap Networks GmbH
next prev parent reply other threads:[~2009-02-06 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 23:46 [PATCH v3 sent again] introduce soft reset handler Bernd Schubert
2009-02-06 7:04 ` Prakash, Sathya
2009-02-06 12:57 ` Bernd Schubert [this message]
2009-02-06 20:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902061358.00067.bs@q-leap.de \
--to=bs@q-leap.de \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Kashyap.Desai@lsi.com \
--cc=Sathya.Prakash@lsi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox