* [PATCH] qla2x: fix printk format warnings
@ 2009-02-18 21:11 Randy Dunlap
2009-02-18 21:16 ` Seokmann Ju
2009-02-18 21:22 ` Matthew Wilcox
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2009-02-18 21:11 UTC (permalink / raw)
To: scsi; +Cc: akpm, jejb, linux-driver
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix qla2xxx printk format warnings:
drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)
drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 6)
drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 5)
drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int format, u64 arg (arg 6)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/scsi/qla2xxx/qla_sup.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--- lnx2629-rc5-docsrc.orig/drivers/scsi/qla2xxx/qla_sup.c
+++ lnx2629-rc5-docsrc/drivers/scsi/qla2xxx/qla_sup.c
@@ -914,7 +914,9 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
DEBUG2(qla_printk(KERN_DEBUG, ha, "NPIV[%02x]: wwpn=%llx "
"wwnn=%llx vf_id=0x%x Q_qos=0x%x F_qos=0x%x.\n", cnt,
- vid.port_name, vid.node_name, le16_to_cpu(entry->vf_id),
+ (unsigned long long)vid.port_name,
+ (unsigned long long)vid.node_name,
+ le16_to_cpu(entry->vf_id),
entry->q_qos, entry->f_qos));
if (i < QLA_PRECONFIG_VPORTS) {
@@ -923,7 +925,8 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
qla_printk(KERN_INFO, ha,
"NPIV-Config: Failed to create vport [%02x]: "
"wwpn=%llx wwnn=%llx.\n", cnt,
- vid.port_name, vid.node_name);
+ (unsigned long long)vid.port_name,
+ (unsigned long long)vid.node_name);
}
}
done:
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] qla2x: fix printk format warnings
2009-02-18 21:11 [PATCH] qla2x: fix printk format warnings Randy Dunlap
@ 2009-02-18 21:16 ` Seokmann Ju
2009-02-18 21:22 ` Matthew Wilcox
1 sibling, 0 replies; 5+ messages in thread
From: Seokmann Ju @ 2009-02-18 21:16 UTC (permalink / raw)
To: Randy Dunlap; +Cc: scsi, akpm, jejb, Linux Driver
On Feb 18, 2009, at 1:11 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix qla2xxx printk format warnings:
Thanks for the patch.
>
>
> drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int
> format, u64 arg (arg 5)
> drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int
> format, u64 arg (arg 6)
> drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int
> format, u64 arg (arg 5)
> drivers/scsi/qla2xxx/qla_sup.c:923: warning: long long unsigned int
> format, u64 arg (arg 6)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Seokmann Ju <seokmann.ju@qlogic.com>
>
> ---
> drivers/scsi/qla2xxx/qla_sup.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> --- lnx2629-rc5-docsrc.orig/drivers/scsi/qla2xxx/qla_sup.c
> +++ lnx2629-rc5-docsrc/drivers/scsi/qla2xxx/qla_sup.c
> @@ -914,7 +914,9 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
>
> DEBUG2(qla_printk(KERN_DEBUG, ha, "NPIV[%02x]: wwpn=%llx "
> "wwnn=%llx vf_id=0x%x Q_qos=0x%x F_qos=0x%x.\n", cnt,
> - vid.port_name, vid.node_name, le16_to_cpu(entry->vf_id),
> + (unsigned long long)vid.port_name,
> + (unsigned long long)vid.node_name,
> + le16_to_cpu(entry->vf_id),
> entry->q_qos, entry->f_qos));
>
> if (i < QLA_PRECONFIG_VPORTS) {
> @@ -923,7 +925,8 @@ qla2xxx_flash_npiv_conf(scsi_qla_host_t
> qla_printk(KERN_INFO, ha,
> "NPIV-Config: Failed to create vport [%02x]: "
> "wwpn=%llx wwnn=%llx.\n", cnt,
> - vid.port_name, vid.node_name);
> + (unsigned long long)vid.port_name,
> + (unsigned long long)vid.node_name);
> }
> }
> done:
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] qla2x: fix printk format warnings
2009-02-18 21:11 [PATCH] qla2x: fix printk format warnings Randy Dunlap
2009-02-18 21:16 ` Seokmann Ju
@ 2009-02-18 21:22 ` Matthew Wilcox
2009-02-18 21:30 ` Andrew Morton
1 sibling, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2009-02-18 21:22 UTC (permalink / raw)
To: Randy Dunlap; +Cc: scsi, akpm, jejb, linux-driver, linux-ia64
On Wed, Feb 18, 2009 at 01:11:20PM -0800, Randy Dunlap wrote:
> drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)
I thought we were going to fix all these by making u64 an unsigned long
long on all 64-bit architectures? I know benh is working on it for
powerpc, and I sent a patch to do it for ia64. Don't think Tony's
merged it yet ...
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qla2x: fix printk format warnings
2009-02-18 21:22 ` Matthew Wilcox
@ 2009-02-18 21:30 ` Andrew Morton
2009-02-18 21:35 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2009-02-18 21:30 UTC (permalink / raw)
To: Matthew Wilcox
Cc: randy.dunlap, linux-scsi, James.Bottomley, linux-driver,
linux-ia64
On Wed, 18 Feb 2009 14:22:50 -0700
Matthew Wilcox <matthew@wil.cx> wrote:
> On Wed, Feb 18, 2009 at 01:11:20PM -0800, Randy Dunlap wrote:
> > drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)
>
> I thought we were going to fix all these by making u64 an unsigned long
> long on all 64-bit architectures? I know benh is working on it for
> powerpc, and I sent a patch to do it for ia64. Don't think Tony's
> merged it yet ...
Yes, we should do this. But momentum seems to have faded again.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qla2x: fix printk format warnings
2009-02-18 21:30 ` Andrew Morton
@ 2009-02-18 21:35 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2009-02-18 21:35 UTC (permalink / raw)
To: Andrew Morton
Cc: Matthew Wilcox, randy.dunlap, linux-scsi, James.Bottomley,
linux-driver, linux-ia64
Andrew Morton wrote:
> On Wed, 18 Feb 2009 14:22:50 -0700
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> On Wed, Feb 18, 2009 at 01:11:20PM -0800, Randy Dunlap wrote:
>>> drivers/scsi/qla2xxx/qla_sup.c:915: warning: long long unsigned int format, u64 arg (arg 5)
>> I thought we were going to fix all these by making u64 an unsigned long
>> long on all 64-bit architectures? I know benh is working on it for
>> powerpc, and I sent a patch to do it for ia64. Don't think Tony's
>> merged it yet ...
>
> Yes, we should do this. But momentum seems to have faded again.
OK. I can help with that then.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-18 21:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 21:11 [PATCH] qla2x: fix printk format warnings Randy Dunlap
2009-02-18 21:16 ` Seokmann Ju
2009-02-18 21:22 ` Matthew Wilcox
2009-02-18 21:30 ` Andrew Morton
2009-02-18 21:35 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox