Re: [GIT PATCH] SCSI fixes for 2.6.29-rc5

Andrew Morton
2009-02-20T23:53:13Z

On Fri, 20 Feb 2009 23:40:56 +0000
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Fri, 2009-02-20 at 15:23 -0800, Andrew Morton wrote:
> > On Fri, 20 Feb 2009 17:02:07 -0600
> > James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> ...
>
> > Did the mpt-fusion MSI problems get sorted out? I think so...
>
> Yes, but in the PCI tree.

OK, fingers crossed for Jesse.

> > I believe that "scsi: mpt: suppress debugobjects warning" is 2.6.29
> > material. Sent 11 Feb, no response.
>
> This is http://bugzilla.kernel.org/show_bug.cgi?id=12662 which is
> reported fixed with no code changes.

I think the followup is bogus.

drivers/message/fusion/mptbase.c:GetLanConfigPages() calls mpt_config()
against an on-stack CONFIGPARMS, which embeds an on-stack timer_list.

So we should still use init_timer_on_stack(). Hopefully that won't
explode if mpt_config() is called with a CONFIGPARMS which _isn't_ on
the stack.

argh, I'll ping Thomas again.

> > Also I believe that "hptiop: add new PCI device ID" should be in 2.6.29
> > (and earlier), below. I can send this on if you like.
>
> I have this marked for inclusion, I'm just sending out the fixes that
> have been incubating in next prior to reconstructing a new fixes tree.

ok, thanks.