* [PATCH] mptsas: remove unneeded check
@ 2009-03-23 10:46 Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2009-03-23 10:46 UTC (permalink / raw)
To: linux-scsi
From: Alan Cox <alan@redhat.com>
>From coverity checker. Closes #9675
(This is a resend. This was discussed before, shown to be a bogus check and
then the change never got applied - hence the origin of the diff being Red Hat)
Signed-off-by: Alan Cox <alan@redhat.com>
---
drivers/message/fusion/mptsas.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 12b7325..a9019f0 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -2279,9 +2279,8 @@ mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
mutex_lock(&ioc->sas_topology_mutex);
list_for_each_entry_safe(port_info, n, &ioc->sas_topology, list) {
- if (port_info->phy_info &&
- (!(port_info->phy_info[0].identify.device_info &
- MPI_SAS_DEVICE_INFO_SMP_TARGET)))
+ if (!(port_info->phy_info[0].identify.device_info &
+ MPI_SAS_DEVICE_INFO_SMP_TARGET))
continue;
if (mptsas_sas_expander_pg0(ioc, &buffer,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] mptsas: remove unneeded check
@ 2009-03-26 20:55 Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2009-03-26 20:55 UTC (permalink / raw)
To: linux-kernel, linux-scsi
From: Alan Cox <alan@redhat.com>
>From coverity checker. Closes #9675
Signed-off-by: Alan Cox <alan@redhat.com>
---
drivers/message/fusion/mptsas.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 12b7325..a9019f0 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -2279,9 +2279,8 @@ mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
mutex_lock(&ioc->sas_topology_mutex);
list_for_each_entry_safe(port_info, n, &ioc->sas_topology, list) {
- if (port_info->phy_info &&
- (!(port_info->phy_info[0].identify.device_info &
- MPI_SAS_DEVICE_INFO_SMP_TARGET)))
+ if (!(port_info->phy_info[0].identify.device_info &
+ MPI_SAS_DEVICE_INFO_SMP_TARGET))
continue;
if (mptsas_sas_expander_pg0(ioc, &buffer,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-26 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-26 20:55 [PATCH] mptsas: remove unneeded check Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2009-03-23 10:46 Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox