From: Chris Wright <chrisw@sous-sol.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Chris Wright <chrisw@sous-sol.org>,
Jean Delvare <jdelvare@suse.de>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH 7/7] libiscsi: fix iscsi pool error path
Date: Thu, 2 Apr 2009 10:26:44 -0700 [thread overview]
Message-ID: <20090402172644.GH18394@sequoia.sous-sol.org> (raw)
In-Reply-To: <49D4E23C.2010201@cs.wisc.edu>
* Mike Christie (michaelc@cs.wisc.edu) wrote:
> Ah, ok, I can agree with passing up errors in general. I did the
> attached patch to propogate the error code upwards. It does not really
> make much difference now. The iscsi pool init caller just checks for
> error or no error and does not even print out the error. It will not
> make tracing errors easier or more difficult. To be useful, we would
> have to propgate the error higher to userspace so the user can see it. I
> do not think I have time to get that in the current feature window, so
> that would have to wait unless you have patches I can test now.
Yup, I think it's just fine as is.
> libiscsi: propogate errors from kfifo_init to iscsi_pool_init callers
>
> Don't convert kfifo_init's error code to -ENOMEM when passing the
> error to the iscsi_pool_init caller.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: Chris Wright <chrisw@sous-sol.org>
prev parent reply other threads:[~2009-04-02 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 18:11 iscsi bugfixes and cleanups michaelc
2009-04-01 18:11 ` [PATCH 1/7] cxgb3i - subscribe to error notification from cxgb3 driver michaelc
2009-04-01 18:11 ` [PATCH 2/7] cxgb3i - re-initialize ddp settings after chip reset michaelc
2009-04-01 18:11 ` [PATCH 3/7] cxgb3i - re-read ddp settings information " michaelc
2009-04-01 18:11 ` [PATCH 4/7] cxgb3i - close all tcp connections upon " michaelc
2009-04-01 18:11 ` [PATCH 5/7] cxgb3i -- merge cxgb3i_ddp into cxgb3i module michaelc
2009-04-01 18:11 ` [PATCH 6/7] cxgb3i: call ddp release function directly michaelc
2009-04-01 18:11 ` [PATCH 7/7] libiscsi: fix iscsi pool error path michaelc
2009-04-02 14:02 ` Jean Delvare
2009-04-02 15:15 ` Mike Christie
2009-04-02 15:27 ` Chris Wright
2009-04-02 16:05 ` Mike Christie
2009-04-02 17:26 ` Chris Wright [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402172644.GH18394@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jdelvare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox