[PATCH 0/6] mpt fusion: Firmware Event implementation using seperate WorkQueue

[PATCH 0/6] mpt fusion: Firmware Event implementation using seperate WorkQueue

[Kashyap, Desai]

These patches are created on top of MPT fusion previous patch applied on
date 26/02/2009 with subject line: "mpt fusion: config, Taskmgmt cmd,
Internal cmd, Ioctl cmd changes"

Some patches are splited into two diffrent patches only for readability
purpose for reviewer.

Consider below patches as one logical patch. There is no harm to send
those patches as single patch, but to give more readability I have choosen
to split.
PATCH 2 and PATCH 3.
PATCH 4 and PATCH 5.

PATCH 3 and PATCH 5 include only those function which are not part of MPT
fusion.
---

Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
---

Re: [PATCH 0/6] mpt fusion: Firmware Event implementation using seperate WorkQueue

[James Bottomley]

On Fri, 2009-04-03 at 17:16 +0530, Kashyap, Desai wrote:
> These patches are created on top of MPT fusion previous patch applied on
> date 26/02/2009 with subject line: "mpt fusion: config, Taskmgmt cmd,
> Internal cmd, Ioctl cmd changes"
> 
> Some patches are splited into two diffrent patches only for readability
> purpose for reviewer.
> 
> Consider below patches as one logical patch. There is no harm to send
> those patches as single patch, but to give more readability I have choosen
> to split.
> PATCH 2 and PATCH 3.
> PATCH 4 and PATCH 5.
> 
> PATCH 3 and PATCH 5 include only those function which are not part of MPT
> fusion.

What actually happened to patch 5?  It looks like you've got two patch
number 4's

[PATCH 4/6] mpt fusion: SAS topology scan changes,Expander events, link status events added
[PATCH 4/6] mpt fusion: Deleted functions for SAS topology scan changes,Expander events, link status events added

But the ordering doesn't look to matter at all, fortunately.

James

RE: [PATCH 0/6] mpt fusion: Firmware Event implementation using seperate WorkQueue

[Desai, Kashyap]

James,


[PATCH 4/6] mpt fusion: Deleted functions for SAS topology scan changes, Expander events, link status events added

It is patch [5/6]. Only numbering is incorrect.

Actually before doing any further changes I was waiting for some feedback, since I have chosen different approach to submit patches.

I have chosen to split one logical patch into two patches. One with all modification and newly added functions, and other with all functions which are not part of mpt fusion. This is just to give more readability to reviewer. If I combine both the patches then patch will not be easily readable.
Is this method really helping you? Or shall I merge those patches into one?



Thanks
Kashyap


-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
Sent: Saturday, April 04, 2009 2:14 AM
To: Desai, Kashyap
Cc: linux-scsi@vger.kernel.org; Moore, Eric; Prakash, Sathya
Subject: Re: [PATCH 0/6] mpt fusion: Firmware Event implementation using seperate WorkQueue

On Fri, 2009-04-03 at 17:16 +0530, Kashyap, Desai wrote:
> These patches are created on top of MPT fusion previous patch applied on
> date 26/02/2009 with subject line: "mpt fusion: config, Taskmgmt cmd,
> Internal cmd, Ioctl cmd changes"
> 
> Some patches are splited into two diffrent patches only for readability
> purpose for reviewer.
> 
> Consider below patches as one logical patch. There is no harm to send
> those patches as single patch, but to give more readability I have choosen
> to split.
> PATCH 2 and PATCH 3.
> PATCH 4 and PATCH 5.
> 
> PATCH 3 and PATCH 5 include only those function which are not part of MPT
> fusion.

What actually happened to patch 5?  It looks like you've got two patch
number 4's

[PATCH 4/6] mpt fusion: SAS topology scan changes,Expander events, link status events added
[PATCH 4/6] mpt fusion: Deleted functions for SAS topology scan changes,Expander events, link status events added

But the ordering doesn't look to matter at all, fortunately.

James