Re: [PATCH] SCSI: add check_capacity flag and sd_read_last_sector()

[Greg KH <greg@kroah.com>]

On Wed, Apr 22, 2009 at 10:42:36AM -0400, Alan Stern wrote:
> This patch (as1196) adds a new scsi_device flag to tell sd.c that it
> should verify the results of READ CAPACITY by trying the read the last
> sector.  This is necessary because a large percentage of USB
> mass-storage devices -- too many for a blacklist -- have a bug whereby
> they return the total number of sectors rather than the index of the
> last sector.
> 
> The new sd_read_last_sector() routine carries out the test, using a
> very short timeout and a small number of retries.  Any working device
> for which the check_capacity flag is set should be able to pass the
> test easily.
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> 
> ---
> 
> James & Greg:
> 
> Although part of this patch touches usb-storage, the majority of 
> it affects SCSI files.  Is it okay if the whole thing goes in via 
> James's tree?

No objection from me at all.  Feel free to add a:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the patch and push it through James.

thanks,

greg k-h