From: Alasdair G Kergon <agk@redhat.com>
To: sekharan@linux.vnet.ibm.com, Hannes Reinecke <hare@suse.de>,
michaelc@cs.wisc.edu
Cc: device-mapper development <dm-devel@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: Re: [PATCH] RFC: have dm-mpath use already attached scsi_dh
Date: Wed, 22 Apr 2009 18:39:08 +0100 [thread overview]
Message-ID: <20090422173907.GC7778@agk.fab.redhat.com> (raw)
In-Reply-To: <1240421544.19442.6.camel@chandra-ubuntu>
On Wed, Apr 22, 2009 at 10:32:24AM -0700, Chandra Seetharaman wrote:
> I agree with Hannes, that we should allow multipath to override the
> default attachment, mainly to give control to the user.
> But, I have a small issue with the attached patch. See below.
> I prefer not to detach a previously attached hardware handler, if
> multipath doesn't have any handler associated with the device. Leaving
> it will not do any hard to multipath as the multipath layer would not
> call scsi_dh_activate for the device.
On balance, I'm inclined to agree - too many layers of config overlapping
here.
If you agree, would one of you like to submit the patch to dm-devel properly,
with appropriate signoffs and a descriptive patch header?
Alasdair
--
agk@redhat.com
prev parent reply other threads:[~2009-04-22 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 4:33 [PATCH] RFC: have dm-mpath use already attached scsi_dh michaelc
2009-04-22 9:16 ` Hannes Reinecke
2009-04-22 13:52 ` Mike Christie
2009-04-22 14:15 ` Hannes Reinecke
2009-04-22 17:32 ` Chandra Seetharaman
2009-04-22 17:39 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422173907.GC7778@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=sekharan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox