Re: [PATCH 0/3] scsi_dh: Make scsi device handler modules automatically inserted

Christoph Hellwig
2009-07-08T18:40:43Z

On Wed, Jul 08, 2009 at 02:33:01PM -0400, Peter Jones wrote:
> This behavior is conditional on the module parameter
> scsi_mod.target_modalias_has_vendor, which has its default set by the
> enabling or disabling of CONFIG_SCSI_TARGET_MODALIAS_WITH_ID .

Sorry, but that's really stupid. If people have the arrays that have
device handlers there are two possible cases:

- just a single port configured on the array. In this case the device
handlers are useless but also completely unharmful.
- multiple ports configured on the array. In this case we desperately
want the device handlers loaded early so that we do the right thing
for the inactive ports and avoid the horrible probing delays, not
matter if we actually do end up using multipath later or no.

No need to make this configurable. If people really do not want the
handler (e.g. becuase the may end up beeing buggy for a new array
matching the old idea) they can just blacklist it in the modules
configuration.