Re: [PATCH 1/3] scsi_dh: Add modalias support for SCSI targets

Chandra Seetharaman
2009-03-18T19:15:24Z

On Wed, 2009-03-18 at 19:30 +0100, Kay Sievers wrote:
> On Wed, Mar 18, 2009 at 02:36, Chandra Seetharaman <sekharan@us.ibm.com> wrote:
> > From: Peter Jones <pjones@redhat.com>
> >
> > This patch allows the use of modaliases on scsi targets to correctly
> > load scsi device handler modules when the devices are found.
> > +++ linux-2.6.28/include/linux/mod_devicetable.h
> > @@ -454,4 +454,10 @@ struct dmi_system_id {
> >
> > #define DMI_MATCH(a, b) { a, b }
> >
> > +struct scsi_dh_device_id {
> > + unsigned char type;
> > + char vendor[9];
> > + char model[17];
> > +};
>
> Doesn't the static array waste space, when used for the long lists of
> entries stuffed in arrays of this structure? It will carry a lot of \0
> chars, and identical strings can not be de-duplicated by the compiler,
> unlike when pointers are used?
>

I had some problems when we used the pointers instead of arrays. Don't
recall it now.

Will retry and report.
> Thanks,
> Kay
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html