Re: [PATCH]: fixing gcc 4.4 compiler warning: suggest parentheses around operand of ‘!’

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 30 Apr 2009 21:31:24 +0000
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Thu, 2009-04-30 at 09:04 +0300, Sergey Senozhatsky wrote:
> > Trivial: fixing gcc 4.4 compiler warning:
> > drivers/scsi/st.c: In function ‘st_int_ioctl’:
> > drivers/scsi/st.c:2967: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
> > 
> > ---
> > 
> > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
> > index eb24efe..2bde8a5 100644
> > --- a/drivers/scsi/st.c
> > +++ b/drivers/scsi/st.c
> > @@ -2964,7 +2964,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
> >  			    !(STp->use_pf & PF_TESTED)) {
> >  				/* Try the other possible state of Page Format if not
> >  				   already tried */
> > -				STp->use_pf = !STp->use_pf | PF_TESTED;
> > +				STp->use_pf = (!STp->use_pf) | PF_TESTED;
> 
> This just doesn't look right.  As I said to the warning reporter, I
> think STp->use_pf |= PF_TESTED; is the correct fix, but I need Kai to
> check this.

yeah, good point.  The code looks very confused.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html