From: Ying Chu <jasonchu@marvell.com>
To: linux-scsi@vger.kernel.org
Cc: jeff@garzik.org, james.bottomley@hansenpartnership.com
Subject: [PATCH 2/4] mvsas: Deadlocks meet when TMF tasks issue
Date: Fri, 8 May 2009 14:16:05 +0800 [thread overview]
Message-ID: <20090508061605.GA1884@jason.marvell.com> (raw)
>From 58f754f51fced4a39adcf708319e3de946a0d61a Mon Sep 17 00:00:00 2001
From: Andy <ayan@marvell.com>
Date: Mon, 4 May 2009 23:31:43 +0800
Subject: [PATCH 2/4] bug fix: deal lock
TMF task need be issued with Interrupt Disabled, or Deadlock may take place.
Signed-off-by: Ying Chu <jasonchu@marvell.com>
Signed-off-by: Andy Yan <ayan@marvell.com>
Signed-off-by: Ke Wei <kewei@marvell.com>
---
drivers/scsi/mvsas/mv_sas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 318ec01..cb002ef 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -1446,7 +1446,7 @@ static int mvs_exec_internal_tmf_task(struct domain_device *dev,
task->timer.expires = jiffies + MVS_TASK_TIMEOUT*HZ;
add_timer(&task->timer);
- res = mvs_task_exec(task, 1, GFP_KERNEL, NULL, 0, 1, tmf);
+ res = mvs_task_exec(task, 1, GFP_KERNEL, NULL, 1, 1, tmf);
if (res) {
del_timer(&task->timer);
--
1.6.0.3
--
Regards,
Ying Chu
next reply other threads:[~2009-05-08 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 6:16 Ying Chu [this message]
2009-05-08 15:49 ` [PATCH 2/4] mvsas: Deadlocks meet when TMF tasks issue James Bottomley
2009-05-08 22:05 ` Jeff Garzik
2009-05-09 7:25 ` Andy Yan
2009-05-09 7:30 ` Jeff Garzik
2009-05-09 15:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508061605.GA1884@jason.marvell.com \
--to=jasonchu@marvell.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox