* [PATCH resend] scsi_lib: remove unused variable
@ 2009-05-19 13:37 Boaz Harrosh
2009-05-19 17:54 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Boaz Harrosh @ 2009-05-19 13:37 UTC (permalink / raw)
To: Jens Axboe, Tejun Heo, FUJITA Tomonori, James Bottomley,
linux-scsi <li>
The last request completion cleanup in scsi_lib left an unused
this_count variable in scsi_io_completion().
(It was used before in a code segment that now uses blk_end_request_all())
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
drivers/scsi/scsi_lib.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index e410d66..d7c6c75 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -706,7 +706,6 @@ EXPORT_SYMBOL(scsi_release_buffers);
void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
{
int result = cmd->result;
- int this_count;
struct request_queue *q = cmd->device->request_queue;
struct request *req = cmd->request;
int error = 0;
@@ -789,7 +788,6 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
*/
if (scsi_end_request(cmd, error, good_bytes, result == 0) == NULL)
return;
- this_count = blk_rq_bytes(req);
error = -EIO;
--
1.6.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH resend] scsi_lib: remove unused variable
2009-05-19 13:37 [PATCH resend] scsi_lib: remove unused variable Boaz Harrosh
@ 2009-05-19 17:54 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-05-19 17:54 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: Tejun Heo, FUJITA Tomonori, James Bottomley, linux-scsi
On Tue, May 19 2009, Boaz Harrosh wrote:
>
> The last request completion cleanup in scsi_lib left an unused
> this_count variable in scsi_io_completion().
> (It was used before in a code segment that now uses blk_end_request_all())
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Thanks, added.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-19 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-19 13:37 [PATCH resend] scsi_lib: remove unused variable Boaz Harrosh
2009-05-19 17:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).