[PATCH 14/24] mpt fusion: [2.6.30-rc6] Deleted functions for Firmware event implementation using seperate WQ

[PATCH 14/24] mpt fusion: [2.6.30-rc6] Deleted functions for Firmware event implementation using seperate WQ

[Kashyap, Desai]

Fuctions which are not used are removed by this patch.
---

Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
---
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 10abd62..29a8fe2 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
@@ -3035,30 +3035,6 @@ mptsas_find_phyinfo_by_sas_address(MPT_ADAPTER *ioc, u64 sas_address)
 	return phy_info;
 }
 
-static struct mptsas_phyinfo *
-mptsas_find_phyinfo_by_target(MPT_ADAPTER *ioc, u8 channel, u8 id)
-{
-	struct mptsas_portinfo *port_info;
-	struct mptsas_phyinfo *phy_info = NULL;
-	int i;
-
-	mutex_lock(&ioc->sas_topology_mutex);
-	list_for_each_entry(port_info, &ioc->sas_topology, list) {
-		for (i = 0; i < port_info->num_phys; i++) {
-			if (!mptsas_is_end_device(
-				&port_info->phy_info[i].attached))
-				continue;
-			if (port_info->phy_info[i].attached.id != id)
-				continue;
-			if (port_info->phy_info[i].attached.channel != channel)
-				continue;
-			phy_info = &port_info->phy_info[i];
-			break;
-		}
-	}
-	mutex_unlock(&ioc->sas_topology_mutex);
-	return phy_info;
-}
 
 static struct mptsas_phyinfo *
 mptsas_find_phyinfo_by_phys_disk_num(MPT_ADAPTER *ioc, u8 channel, u8 id)

Re: [PATCH 14/24] mpt fusion: [2.6.30-rc6] Deleted functions for Firmware event implementation using seperate WQ

[James Bottomley]

On Fri, 2009-05-22 at 16:34 +0530, Kashyap, Desai wrote:
> Fuctions which are not used are removed by this patch.
> ---
> 
> Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
> ---
> diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> index 10abd62..29a8fe2 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -3035,30 +3035,6 @@ mptsas_find_phyinfo_by_sas_address(MPT_ADAPTER *ioc, u64 sas_address)
>  	return phy_info;
>  }
>  
> -static struct mptsas_phyinfo *
> -mptsas_find_phyinfo_by_target(MPT_ADAPTER *ioc, u8 channel, u8 id)

Please combine this with the patch that actually removes the last use
otherwise, for all static functions, gcc is going to warn about defined
but unused functions.

The 10 lines you save by separating this aren't really significant given
that some of the other patches are up to a thousand lines.

James