From: Greg KH <gregkh@suse.de>
To: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: PATCH: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller
Date: Wed, 10 Jun 2009 18:23:19 -0700 [thread overview]
Message-ID: <20090611012319.GC31460@suse.de> (raw)
In-Reply-To: <alpine.LNX.1.10.0906101259500.24722@rslab159.pmc-sierra.bc.ca>
On Wed, Jun 10, 2009 at 01:07:12PM -0700, Anil Ravindranath wrote:
> Hi,
>
> This patch adds a driver to support PMC-Sierra 6Gb/s SAS RAID controller.
> This patch is created against scsi-misc-2.6.git.
You forgot a "Signed-off-by:" line, that will be necessary for anyone to
be able to accept this patch :(
> +static struct pci_device_id pmcraid_pci_table[] __devinitdata = {
> + {PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_MAXRAID,
> + PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + (kernel_ulong_t)&pmcraid_chip_cfg[0]
> + },
> + {PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_0x8010,
> + PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + (kernel_ulong_t)&pmcraid_chip_cfg[0]
> + },
Minor nit, you can use the PCI_DRIVER() macro here to make it a bit
cleaner.
thanks,
greg k-h
next prev parent reply other threads:[~2009-06-11 1:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 20:07 PATCH: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller Anil Ravindranath
2009-06-11 1:23 ` Greg KH [this message]
2009-06-11 5:54 ` Anil Ravindranath
2009-06-13 7:04 ` Anil Ravindranath
2009-06-11 3:14 ` Grant Grundler
2009-06-11 13:11 ` Anil Ravindranath
2009-06-13 7:18 ` Anil Ravindranath
2009-06-11 11:47 ` Rolf Eike Beer
2009-06-11 13:25 ` Anil Ravindranath
2009-06-11 14:08 ` James Bottomley
2009-06-13 8:50 ` Anil Ravindranath
2009-06-11 16:32 ` Brian King
2009-06-12 6:06 ` Anil Ravindranath
2009-06-12 15:08 ` Grant Grundler
2009-06-12 15:23 ` Brian King
2009-06-12 16:17 ` Brian King
2009-06-12 16:20 ` Grant Grundler
2009-06-12 16:43 ` James Bottomley
2009-06-12 15:24 ` James Bottomley
2009-06-16 14:10 ` Anil Ravindranath
2009-06-16 17:08 ` Greg KH
2009-06-17 15:09 ` Brian King
2009-06-18 18:08 ` Anil Ravindranath
-- strict thread matches above, loose matches on Subject: below --
2009-06-16 17:37 Anil Ravindranath
2009-06-16 18:48 ` Randy Dunlap
2009-06-17 11:04 ` Anil Ravindranath
2009-08-07 0:16 Anil Ravindranath
2009-08-18 21:44 ` Anil Ravindranath
2009-08-19 2:02 ` James Bottomley
2009-08-24 17:24 ` Anil Ravindranath
2009-08-26 0:35 Anil Ravindranath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611012319.GC31460@suse.de \
--to=gregkh@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anil_ravindranath@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox