Re: PATCH: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller

Anil Ravindranath
2009-06-11T06:35:07Z

On Wed, 10 Jun 2009, Greg KH wrote:

> On Wed, Jun 10, 2009 at 01:07:12PM -0700, Anil Ravindranath wrote:
> > Hi,
> >
> > This patch adds a driver to support PMC-Sierra 6Gb/s SAS RAID controller.
> > This patch is created against scsi-misc-2.6.git.
>
> You forgot a "Signed-off-by:" line, that will be necessary for anyone to
> be able to accept this patch :(
>
Oops. Sorry.

SIGNED-OFF-BY: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>

> > +static struct pci_device_id pmcraid_pci_table[] __devinitdata = {
> > + {PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_MAXRAID,
> > + PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> > + (kernel_ulong_t)&pmcraid_chip_cfg[0]
> > + },
> > + {PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_0x8010,
> > + PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> > + (kernel_ulong_t)&pmcraid_chip_cfg[0]
> > + },
>
> Minor nit, you can use the PCI_DRIVER() macro here to make it a bit
> cleaner.
>
Sure. I will look into this and modify accordingly.

> thanks,
>
> greg k-h
>