* Re: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX [not found] <200907012018.13695.jdelvare@suse.de> @ 2009-07-01 19:33 ` James Bottomley 2009-07-01 19:42 ` Kurt Garloff 2009-07-02 8:23 ` Jean Delvare 0 siblings, 2 replies; 5+ messages in thread From: James Bottomley @ 2009-07-01 19:33 UTC (permalink / raw) To: Jean Delvare; +Cc: linux-scsi, Kurt Garloff, Hannes Reinecke On Wed, 2009-07-01 at 20:18 +0200, Jean Delvare wrote: > From: Kurt Garloff <garloff@suse.de> > > All EMC SYMMETRIX support REPORT_LUNS, even if configured to report > SCSI-2 for whatever reason. > > Signed-off-by: Kurt Garloff <garloff@suse.de> > Signed-off-by: Hannes Reinecke <hare@suse.de> > Signed-off-by: Jean Delvare <jdelvare@suse.de> > --- > We have this fix in our SLES10 kernel for over a year now, I guess > it's about time to get it upstream so that everyone benefits. > > Patch already sent on: > * 2009-05-29 The SCSI mailing list doesn't find it. > drivers/scsi/scsi_devinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- root.orig/drivers/scsi/scsi_devinfo.c > +++ root/drivers/scsi/scsi_devinfo.c > @@ -152,7 +152,7 @@ static struct { > {"DGC", "RAID", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, storage on LUN 0 */ > {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, no storage on LUN 0 */ > {"EMC", "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, > - {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN}, > + {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_REPORTLUN2}, You don't actually need SPARSE or LARGELUN ... that's implied by REPORTLUN2, so only REPORTLUN2 is needed here. > {"EMULEX", "MD21/S2 ESDI", NULL, BLIST_SINGLELUN}, > {"easyRAID", "16P", NULL, BLIST_NOREPORTLUN}, > {"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN}, James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX 2009-07-01 19:33 ` [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX James Bottomley @ 2009-07-01 19:42 ` Kurt Garloff 2009-07-02 14:38 ` berthiaume_wayne 2009-07-02 8:23 ` Jean Delvare 1 sibling, 1 reply; 5+ messages in thread From: Kurt Garloff @ 2009-07-01 19:42 UTC (permalink / raw) To: James Bottomley; +Cc: Jean Delvare, linux-scsi, Hannes Reinecke [-- Attachment #1: Type: text/plain, Size: 1786 bytes --] James, On Wed, Jul 01, 2009 at 07:33:32PM +0000, James Bottomley wrote: > > --- root.orig/drivers/scsi/scsi_devinfo.c > > +++ root/drivers/scsi/scsi_devinfo.c > > @@ -152,7 +152,7 @@ static struct { > > {"DGC", "RAID", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, storage on LUN 0 */ > > {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, no storage on LUN 0 */ > > {"EMC", "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, > > - {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN}, > > + {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_REPORTLUN2}, > > You don't actually need SPARSE or LARGELUN ... that's implied by > REPORTLUN2, so only REPORTLUN2 is needed here. When I created the patch, all SYMMETRIXes that I had ever been exposed to did support REPORT_LUNs, but I was not sure that every single SYMMETRIX out there would actually support it. So in case some old SYMMETRIX would not and the kernel would fall back to sequential scanning, we would still find all LUNs by not dropping SPARSELUN and LARGELUN. (Dropping FORCELUN on the other hand was absolutely right; the flag is broken by design anyway and should never be used.) So leaving in SPARSELUN and LARGELUN was not an oversight, but really trying to be conservative. If you have additional insight (you positively know that every SYMMETRIX does support REPORT_LUNS) or you want to force possible devices that do not support it into the open by breaking them, then remove the two flags. > > {"EMULEX", "MD21/S2 ESDI", NULL, BLIST_SINGLELUN}, > > {"easyRAID", "16P", NULL, BLIST_NOREPORTLUN}, > > {"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN}, Best, -- Kurt Garloff, VP OPS Partner Engineering -- Novell Inc. [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX 2009-07-01 19:42 ` Kurt Garloff @ 2009-07-02 14:38 ` berthiaume_wayne 2009-07-02 15:35 ` James Bottomley 0 siblings, 1 reply; 5+ messages in thread From: berthiaume_wayne @ 2009-07-02 14:38 UTC (permalink / raw) To: garloff, James.Bottomley; +Cc: jdelvare, linux-scsi, hare There are still very old Symmetrix arrays out there that could be broken if we drop BLIST_SPARSELUN or BLIST_LARGELUN because they don't support REPORT_LUNS. Regards, Wayne. -----Original Message----- From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Kurt Garloff Sent: Wednesday, July 01, 2009 3:42 PM To: James Bottomley Cc: Jean Delvare; linux-scsi@vger.kernel.org; Hannes Reinecke Subject: Re: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX James, On Wed, Jul 01, 2009 at 07:33:32PM +0000, James Bottomley wrote: > > --- root.orig/drivers/scsi/scsi_devinfo.c > > +++ root/drivers/scsi/scsi_devinfo.c > > @@ -152,7 +152,7 @@ static struct { > > {"DGC", "RAID", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, storage on LUN 0 */ > > {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, no storage on LUN 0 */ > > {"EMC", "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, > > - {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN}, > > + {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_REPORTLUN2}, > > You don't actually need SPARSE or LARGELUN ... that's implied by > REPORTLUN2, so only REPORTLUN2 is needed here. When I created the patch, all SYMMETRIXes that I had ever been exposed to did support REPORT_LUNs, but I was not sure that every single SYMMETRIX out there would actually support it. So in case some old SYMMETRIX would not and the kernel would fall back to sequential scanning, we would still find all LUNs by not dropping SPARSELUN and LARGELUN. (Dropping FORCELUN on the other hand was absolutely right; the flag is broken by design anyway and should never be used.) So leaving in SPARSELUN and LARGELUN was not an oversight, but really trying to be conservative. If you have additional insight (you positively know that every SYMMETRIX does support REPORT_LUNS) or you want to force possible devices that do not support it into the open by breaking them, then remove the two flags. > > {"EMULEX", "MD21/S2 ESDI", NULL, BLIST_SINGLELUN}, > > {"easyRAID", "16P", NULL, BLIST_NOREPORTLUN}, > > {"easyRAID", "X6P", NULL, BLIST_NOREPORTLUN}, Best, -- Kurt Garloff, VP OPS Partner Engineering -- Novell Inc. ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX 2009-07-02 14:38 ` berthiaume_wayne @ 2009-07-02 15:35 ` James Bottomley 0 siblings, 0 replies; 5+ messages in thread From: James Bottomley @ 2009-07-02 15:35 UTC (permalink / raw) To: berthiaume_wayne; +Cc: garloff, jdelvare, linux-scsi, hare On Thu, 2009-07-02 at 10:38 -0400, berthiaume_wayne@emc.com wrote: > There are still very old Symmetrix arrays out there that could be broken > if we drop BLIST_SPARSELUN or BLIST_LARGELUN because they don't support > REPORT_LUNS. OK, as long as all the older arrays correctly return ILLEGAL REQUEST to a REPORT LUNS command, we'll be fine. James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX 2009-07-01 19:33 ` [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX James Bottomley 2009-07-01 19:42 ` Kurt Garloff @ 2009-07-02 8:23 ` Jean Delvare 1 sibling, 0 replies; 5+ messages in thread From: Jean Delvare @ 2009-07-02 8:23 UTC (permalink / raw) To: James Bottomley; +Cc: linux-scsi, Kurt Garloff, Hannes Reinecke Le mercredi 01 juillet 2009, James Bottomley a écrit : > On Wed, 2009-07-01 at 20:18 +0200, Jean Delvare wrote: > > From: Kurt Garloff <garloff@suse.de> > > > > All EMC SYMMETRIX support REPORT_LUNS, even if configured to report > > SCSI-2 for whatever reason. > > > > Signed-off-by: Kurt Garloff <garloff@suse.de> > > Signed-off-by: Hannes Reinecke <hare@suse.de> > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > --- > > We have this fix in our SLES10 kernel for over a year now, I guess > > it's about time to get it upstream so that everyone benefits. > > > > Patch already sent on: > > * 2009-05-29 > > The SCSI mailing list doesn't find it. Indeed. Very strange, as my mailer is positive it did send it. Must have been lost on the road... sorry. -- Jean Delvare Suse L3 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-02 15:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200907012018.13695.jdelvare@suse.de>
2009-07-01 19:33 ` [PATCH] Add BLIST_REPORTLUN2 to EMC SYMMETRIX James Bottomley
2009-07-01 19:42 ` Kurt Garloff
2009-07-02 14:38 ` berthiaume_wayne
2009-07-02 15:35 ` James Bottomley
2009-07-02 8:23 ` Jean Delvare
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox